Bug #60923 [Com]: Failing tests for sapi/cli
Edit report at https://bugs.php.net/bug.php?id=60923&edit=1
ID: 60923
Comment by: robertbasic dot com at gmail dot com
Reported by: robertbasic dot com at gmail dot com
Summary: Failing tests for sapi/cli
Status: Feedback
Type: Bug
Package: CGI/CLI related
Operating System: GNU/Linux (Fedora 16)
PHP Version: 5.4SVN-2012-01-29 (SVN)
Block user comment: N
Private report: N
New Comment:
Think I narrowed it down even more. Seems to me the problem is in the new php_output_stderr function
- when I comment it out, the tests pass again. I'll attach a diff to show what I did.
Previous Comments:
------------------------------------------------------------------------
[2012-01-29 16:21:26] robertbasic dot com at gmail dot com
Hello again!
I did a svn log -r {2012-01-10}:HEAD against the PHP54 branch and went through those commits.
What I've managed to do so far is to find what commit is causing the tests to fail (at least I
think it's this one): http://svn.php.net/viewvc?view=revision&revision=322743
The r322743 of the code has the tests failing, while the one prior to it (r322678) has the tests
passing.
Sadly my C skills are almost non-existent, so I can't promise a patch, but will continue to
poke around it.
------------------------------------------------------------------------
[2012-01-29 14:24:04] robertbasic dot com at gmail dot com
Will do.
By looking at the expected and the actual outputs of sapi/cli/tests/001.phpt, looks like that
var_dump($php -n -v); first prints out the PHP version (the result from php -n -v) and
then var_dumps a NULL, whereas it should var_dump the result from php -n -v.
Actually, all these failing tests are this kind of thing: printing the result, var_dumping NULL,
instead of var_dumping the result. What's strange, is that, for example
sapi/cli/tests/007.phpt, from 3 var_dumps in that test, only one does this (the 2nd), the other 2
work as expected.
Given that this works for RC6, I'm looking at commits since then, to see if anything from there
is causing this.
Any hints on what should I do to check is my system affecting this somehow? I'm using the test
instructions you posted on codepad some time ago.
Thanks!
------------------------------------------------------------------------
[2012-01-29 13:50:42] rasmus@php.net
I am not seeing these failures here. Could you dig into one of them to see if you
can figure out why it is failing for you?
------------------------------------------------------------------------
[2012-01-29 12:20:21] robertbasic dot com at gmail dot com
Description:
------------
After checking out PHP54 from branches/PHP_5_4, running:
./buildconf
./configure
make
make test
some tests for sapi/cli are failing. These tests were OK when I tested from tags/php_5_4_0RC6
The failing tests are:
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
version string [sapi/cli/tests/001.phpt]
strip comments and whitespace with -w [sapi/cli/tests/007.phpt]
execute a file with -f [sapi/cli/tests/008.phpt]
using invalid combinations of cmdline options [sapi/cli/tests/009.phpt]
syntax check [sapi/cli/tests/011.phpt]
invalid arguments and error messages [sapi/cli/tests/012.phpt]
syntax highlighting [sapi/cli/tests/014.phpt]
CLI long options [sapi/cli/tests/015.phpt]
=====================================================================
Full reports were submitted to http://qa.php.net/reports/
after running the tests.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=60923&edit=1
Thread (9 messages)