Bug #60948 [NEW]: mysqlnd FTBFS when -Wformat-security is enabled

From: ondrej Operating system: Any PHP version: 5.4.0RC6 Package: MySQL related Bug Type: Bug Bug description:mysqlnd FTBFS when -Wformat-security is enabled Description: ------------ $ svn diff Index: ext/mysqlnd/mysqlnd_wireprotocol.c =================================================================== --- ext/mysqlnd/mysqlnd_wireprotocol.c (revision 322993) +++ ext/mysqlnd/mysqlnd_wireprotocol.c (working copy) @@ -500,7 +500,7 @@ const char * const msg = "Authentication data too long. " "Won't fit into the buffer and will be truncated. Authentication will thus fail"; SET_CLIENT_ERROR(*conn->error_info, CR_UNKNOWN_ERROR, UNKNOWN_SQLSTATE, msg); - php_error_docref(NULL TSRMLS_CC, E_WARNING, msg); + php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s", msg); DBG_RETURN(0); } -- Edit bug report at https://bugs.php.net/bug.php?id=60948&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=60948&r=trysnapshot54 Try a snapshot (PHP 5.3): https://bugs.php.net/fix.php?id=60948&r=trysnapshot53 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=60948&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=60948&r=fixed Fixed in SVN and need be documented: https://bugs.php.net/fix.php?id=60948&r=needdocs Fixed in release: https://bugs.php.net/fix.php?id=60948&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=60948&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=60948&r=needscript Try newer version: https://bugs.php.net/fix.php?id=60948&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=60948&r=support Expected behavior: https://bugs.php.net/fix.php?id=60948&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=60948&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=60948&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=60948&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=60948&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=60948&r=dst IIS Stability: https://bugs.php.net/fix.php?id=60948&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=60948&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=60948&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=60948&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=60948&r=mysqlcfg