Edit report at https://bugs.php.net/bug.php?id=60708&edit=1
ID: 60708
Patch added by: laruence@php.net
Reported by: masugata at gmail dot com
Summary: segmentation fault, use max_input_vars
Status: Assigned
Type: Bug
Package: *General Issues
Operating System: x86_64 GNU/Linux
PHP Version: 5.3.9
Assigned To: dmitry
Block user comment: N
Private report: N
New Comment:
The following patch has been added/updated:
Patch Name: memleak_fix_for_bug60708
Revision: 1328173952
URL: https://bugs.php.net/patch-display.php?bug=60708&patch=memleak_fix_for_bug60708&revision=1328173952
Previous Comments:
------------------------------------------------------------------------
[2012-02-02 09:02:16] pajoye@php.net
Assign to Dmitry as he is working on that now.
------------------------------------------------------------------------
[2012-02-02 08:58:46] laruence@php.net
fix for leaks referred by Pierre:
--- php_variables.c (revision 323011)
+++ php_variables.c (working copy)
@@ -187,6 +187,10 @@
array_init(gpc_element);
zend_symtable_update(symtable1,
escaped_index, index_len + 1, &gpc_element, sizeof(zval *), (void **)
&gpc_element_p);
} else {
+ if (index != escaped_index) {
+ efree(escaped_index);
+ }
+ zval_dtor(val);
free_alloca(var_orig, use_heap);
return;
}
------------------------------------------------------------------------
[2012-02-02 08:00:21] huzaifas at redhat dot com
Is this bug fixed by the following svn commit?
http://svn.php.net/viewvc?view=revision&revision=323007
------------------------------------------------------------------------
[2012-02-02 07:55:42] pajoye@php.net
Are you sure the fix is complete? There are leaks afaik.
------------------------------------------------------------------------
[2012-02-02 07:29:21] stas@php.net
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
Thanks, should be fine in current SVN.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=60708--
Edit this bug report at https://bugs.php.net/bug.php?id=60708&edit=1