#18905 [Com]: apache 2.0.40 changed template for register_*_filter adding additional arg

ID: 18905 Comment by: duke@mastre.com Reported By: jon.tankersley@eds.com Status: Closed Bug Type: Apache related Operating System: Solaris 2.8 PHP Version: 4.2.2 New Comment: As far as I can tell that was fixed in the STABLE snapshot as well. It used to be MODULE_MAGIC_AT_LEAST, with the fix being changing it to AP_MODULE_MAGIC_AT_LEAST (this is the case in 4.2.2-RELEASE). sapi/apache2filter/php_functions.c from php4-STABLE-200208140900 no longer contains this code, only #if MODULE_MAGIC_NUMBER < 20020506 ADD_STRING(boundary); #endif This appears to be current (meaning: I did not get any complaints ;) So stable should be fine after all. Previous Comments: ------------------------------------------------------------------------ [2002-08-14 13:43:38] jon.tankersley@eds.com Adding a NULL as parameter 3 is okay..... but php_functions.c for some reason is using a deprecated macro..... MODULE_MAGIC_AT_LEAST I don't know if it was in 4.2.1, I blew that away last night. The unstable might be a better bet. ------------------------------------------------------------------------ [2002-08-14 12:56:46] duke@mastre.com So the fix is..: Either use the latest PHP non-STABLE snapshot (as of now, php4-200208140900), or use php4-STABLE-200208140900 and modify sapi/apache2filter/sapi_apache2.c and add NULL as parameter 3 for ap_register_*_filter (lines 567 & 568). ------------------------------------------------------------------------ [2002-08-14 12:36:17] jon.tankersley@eds.com It wasn't in the latest download from the php.net main site or easily found in the bugs database. There may also be a problem with the 4.2.1-4.2.2 unified diff file. That failed with a missing data at the end and I then went after the 4.2.2 full source tree. Thanks for the quick turn around though. ------------------------------------------------------------------------ [2002-08-14 12:04:21] jon.tankersley@eds.com Found reference in the Apache changes: *) Add a filter_init parameter to the filter registration functions so that a filter can execute arbitrary code before the handlers are invoked. This resolves a problem where mod_include requests would incorrectly return a 304. [Justin Erenkrantz] ------------------------------------------------------------------------ [2002-08-14 11:49:52] edink@php.net Just to to clarify: This bug has been fixed in CVS. You can grab a snapshot of the CVS version at http://snaps.php.net/. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/18905 -- Edit this bug report at http://bugs.php.net/?id=18905&edit=1