Edit report at https://bugs.php.net/bug.php?id=61529&edit=1
ID: 61529
Updated by: dmitry@php.net
Reported by: asserte at gmail dot com
Summary: Make unset() an expression
-Status: Verified
+Status: Feedback
Type: Feature/Change Request
Package: Scripting Engine problem
Operating System: Linux
PHP Version: 5.4.1RC/5.5.0-dev
Block user comment: N
Private report: N
New Comment:
I didn't test the patch just made a quick review. I suppose it's incomplete. With patch
it's possible to write $a = unset($b), but UNSET opcode doesn't care about return value,
so what's going to be assigned to $a?
In any case, I think, such changes are not allowed in minor releases. So must not be committed into
5.4. Personally, I don't think it makes sense for trunk as well. It always possible to write
if (isset($entity['id'])) unset($entity['id']);
More clear, and just a few characters more :)
Previous Comments:
------------------------------------------------------------------------
[2012-03-29 15:34:49] laruence@php.net
@nikic @reeze, after a deep thought, I realize that I was wrong. yes, to fix this
we should make unset return something..
so, mark it as a req ,
thanks
------------------------------------------------------------------------
[2012-03-29 14:59:36] laruence@php.net
@nikic thinking of isset, include. :)
------------------------------------------------------------------------
[2012-03-29 14:59:27] laruence@php.net
@nikic thinking of isset, include. :)
------------------------------------------------------------------------
[2012-03-29 13:28:04] nikic@php.net
unset() is a statement, not an expression. So you obviously can't use it in an expression
context. Changing buy type to Feature Request.
In my eyes the behavior *should not* be changed. unset() does not have a meaningful return value and
as such should not be allowed in an expression context.
------------------------------------------------------------------------
[2012-03-29 13:07:36] reeze dot xia at gmail dot com
unset() is like echo These are language constuct, Both of them are not
expression in PHP, so code like this:
$c = 1 && echo 3;
IS NOT VALID script too;
Those language construct are "unticked_statement" @see
Zend/zend_language_parser.y.
if,switch, do while and etc they all.
So from now on, This is not a bug.
Maybe we could make unset() a normal expression. I don't know how this decision
made, maybe we can discuss it in maillist.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=61529
--
Edit this bug report at https://bugs.php.net/bug.php?id=61529&edit=1