Bug #61460 [Opn->Csd]: popen_close_error-win32 expected output is wrong
| From: | ab@php.net | Date: | Tue, 03 Apr 2012 12:30:00 +0000 |
| Subject: | Bug #61460 [Opn->Csd]: popen_close_error-win32 expected output is wrong | ||
| References: | 1 | Groups: | php.bugs php.qa |
| Request: | Send a blank email to php-bugs+get-169190@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=61460&edit=1
ID: 61460
Updated by: ab@php.net
Reported by: mattficken@php.net
Summary: popen_close_error-win32 expected output is wrong
-Status: Open
+Status: Closed
Type: Bug
Package: Testing related
Operating System: Windows
PHP Version: 5.3.10
-Assigned To:
+Assigned To: ab
Block user comment: N
Private report: N
New Comment:
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
Previous Comments:
------------------------------------------------------------------------
[2012-04-03 12:28:38] mattficken@php.net
Automatic comment on behalf of mattficken
Revision: http://git.php.net/?p=php-src.git;a=commit;h=438536e45e1f762fd0f0fe7d9243adb63074e55d
Log: Fix bug #61460 popen_close_error-win32 expected output is wrong
------------------------------------------------------------------------
[2012-04-02 22:59:23] mattficken@php.net
This patch passes on PHP5.3.11rc1 on Windows 7 sp1x64.
It does not break for me on Linux x64 (Gentoo and Fedora 16) with PHP5.3.11rc1.
------------------------------------------------------------------------
[2012-03-20 22:56:43] mattficken@php.net
This patch fixes it:
20c20
< echo "*** Testing for error conditions ***\n";
---
> echo "*** Testing for error conditions ***".PHP_EOL;
22a23
>
23a25
>
29c31
< echo "\n--- Done ---";
---
> echo PHP_EOL.PHP_EOL."--- Done ---";
44,46c46,48
< resource(%d) of type (stream)
< 'abc.txt' is not recognized as an internal or external command,
< operable program or batch file.
---
>
> Warning: popen(abc.txt,rw): Invalid argument in %s on line %d
> bool(false)
57c59,61
< --- Done ---
---
>
> --- Done ---'abc.txt' is not recognized as an internal or external command,
> operable program or batch file.
------------------------------------------------------------------------
[2012-03-20 22:54:08] mattficken@php.net
Description:
------------
Warning messages have changed since test written. Expected output is incorrect. See patch.
Expected result:
----------------
test pass
Actual result:
--------------
test fail
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=61460&edit=1