Bug #61610 [Com]: Test ext\date\tests\date_default_timezone_get-1.diff fails

From: Date: Tue, 10 Apr 2012 01:56:57 +0000
Subject: Bug #61610 [Com]: Test ext\date\tests\date_default_timezone_get-1.diff fails
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-169376@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=61610&edit=1

 ID:                 61610
 Comment by:         mattficken@php.net
 Reported by:        ab@php.net
 Summary:            Test ext\date\tests\date_default_timezone_get-1.diff
                     fails
 Status:             Open
 Type:               Bug
 Package:            Date/time related
 Operating System:   Windows
 PHP Version:        5.3.10
 Block user comment: N
 Private report:     N

 New Comment:

There is a slight typo on the first patch(date_default_timezone_get-2 instead of
date_default_timezone_get-1).

The second patch fixes it


Previous Comments:
------------------------------------------------------------------------
[2012-04-10 01:55:55] mattficken@php.net

The following patch has been added/updated:

Patch Name: bug61610-2.diff.patch.txt
Revision:   1334022955
URL:        https://bugs.php.net/patch-display.php?bug=61610&patch=bug61610-2.diff.patch.txt&revision=1334022955

------------------------------------------------------------------------
[2012-04-03 18:13:55] ab@php.net

Tested on debian and win7 both x86.

------------------------------------------------------------------------
[2012-04-03 18:01:07] ab@php.net

The behaviour on windows is to select an arbitrary timezone from the current system settings. This
gives no chance to hardcode the timezone name, for instance for UTC+1 it could choose from the
multiple names like Europe/Berlin or Europe/Paris . For this reason the test is parametrized so
there is no hardcoded timezone data.

The original test made to be skipped on windows and a duplicate was made for windows.

------------------------------------------------------------------------
[2012-04-03 17:59:10] ab@php.net

The following patch has been added/updated:

Patch Name: 61610.diff
Revision:   1333475950
URL:        https://bugs.php.net/patch-display.php?bug=61610&patch=61610.diff&revision=1333475950

------------------------------------------------------------------------
[2012-04-03 16:31:15] ab@php.net

Description:
------------
Current test diff

01+ Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone
settings. You are *required* to use the date.timezone
setting or the date_default_timezone_set() function. In case you used any of those methods and you
are still getting this warning, you most likely misspelled the timezone identifier. We selected
'Europe/Paris' for '2.0/DST' instead in
C:\php-sdk\php53\vc9\x86\php-src\ext\date\tests\date_default_timezone_get-1.php on line 3
002+ Europe/Paris
001- Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone
settings. You are *required* to use the date.timezone
setting or the date_default_timezone_set() function. In case you used any of those methods and you
are still getting this warning, you most likely misspelled the timezone identifier. We selected
'UTC' for 'UTC/0.0/no DST' instead in %sdate_default_timezone_get-1.php on line
3
002- UTC
004+ Warning: date(): It is not safe to rely on the system's timezone settings. You are
*required* to use the date.timezone setting or the date_default_timezone_set() function. In case you
used any of those methods and you are still getting this warning, you most likely misspelled the
timezone identifier. We selected 'Europe/Paris' for '2.0/DST' instead in
C:\php-sdk\php53\vc9\x86\php-src\ext\date\tests\date_default_timezone_get-1.php on line 4
005+ Europe/Paris
004- Warning: date(): It is not safe to rely on the system's timezone settings. You are
*required* to use the date.timezone setting or the date_default_timezone_set() function. In case you
used any of those methods and you are still getting this warning, you most likely misspelled the
timezone identifier. We selected 'UTC' for 'UTC/0.0/no DST' instead in
%sdate_default_timezone_get-1.php on line 4
005- UTC

Expected result:
----------------
test pass

Actual result:
--------------
test fail


------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=61610&edit=1


Thread (8 messages)

« previous php.bugs (#169376) next »