Edit report at https://bugs.php.net/bug.php?id=61769&edit=1
ID: 61769
Comment by: ab@php.net
Reported by: mattficken@php.net
Summary: Random failure of php_cli_server*phpt tests
Status: Open
Type: Bug
Package: Built-in web server
PHP Version: 5.4.0
Block user comment: N
Private report: N
New Comment:
just came into my mind - may be it would have an effect if we just set a timeout at the top of the
php_cli_server_start() too? so the previous server had a chance to exit ...
Previous Comments:
------------------------------------------------------------------------
[2012-04-19 14:34:18] ab@php.net
Matt, unfortunately I can't reproduce the fails on my laptops, they're probably too slow.
Nevertheless I'm not sure the patch does expected things. I've just debugged on win7 and
ubuntu - SO_REUSEADDR is defined everywhere. MSDN even says it's available on all the versions.
This means setsockopt should work as expected.
Besides that, removing that wrapping #ifdef could have impacts in some rare cases, i think, as
SO_REUSEADDR is marked as a BSD macro, so despite it's luckily present on GNU, it might be
absent on some POSIX-complaint only systems. Could you please explain why this fix is correct?
Also the php_cli_server_017.phpt was still failing for me, but that's just the unix/windows dir
separator.
------------------------------------------------------------------------
[2012-04-19 14:15:26] ab@php.net
The following patch has been added/updated:
Patch Name: php_cli_server_017.diff
Revision: 1334844926
URL: https://bugs.php.net/patch-display.php?bug=61769&patch=php_cli_server_017.diff&revision=1334844926
------------------------------------------------------------------------
[2012-04-18 21:21:00] mattficken@php.net
Description:
------------
All the php_cli_server* tests randomly fail.
Each test starts and stops the builtin web server. The web server when restarted quickly, can't
listen on the given port because its locked by the OS.
The SO_REUSEADDR option needs to be set on the web server's socket.
Test script:
---------------
007+ string(82)
"C:\php-sdk\php-test-pack-5.4-nts-windows-vc9-x86-re7a36ad\Sapi\cli\tests\index.php"
007- string(%d) "%s/tests/index.php"
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=61769&edit=1