Req #61602 [Opn]: Allow access to name of constant used as default value

From: Date: Tue, 15 May 2012 07:11:29 +0000
Subject: Req #61602 [Opn]: Allow access to name of constant used as default value
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-170445@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=61602&edit=1

 ID:                 61602
 Updated by:         sebastian@php.net
 Reported by:        sebastian@php.net
 Summary:            Allow access to name of constant used as default
                     value
 Status:             Open
 Type:               Feature/Change Request
 Package:            Reflection related
 Operating System:   Irrelevant
 PHP Version:        5.4Git-2012-04-02 (Git)
 Block user comment: N
 Private report:     N

 New Comment:

Updated example script that uses new method names:

➜  ~  cat test.php 
<?php
class Foo {
    const bar = '...';

    public function baz($bar = self::bar) {
    }
}

$m = new ReflectionMethod('Foo', 'baz');
$p = $m->getParameters();

foreach ($p as $_p) {
    var_dump($_p->isDefaultValueConstant());

    if ($_p->isDefaultValueConstant()) {
        var_dump($_p->getDefaultValueConstantName());
    }
}

➜  ~  php test.php 
bool(true)
string(9) "self::bar"


Previous Comments:
------------------------------------------------------------------------
[2012-04-25 06:10:22] sebastian@php.net

Can we at least merge the patch into master? Once it's there we can think about merging it into
PHP 5.4 for PHP 5.4.2.

------------------------------------------------------------------------
[2012-04-08 00:45:21] stas@php.net

Not very likely for 5.4.1, doesn't seem to be a critical bug. For 5.4.2, maybe.

------------------------------------------------------------------------
[2012-04-03 09:22:42] sebastian@php.net

Any chance this pull request will be merged into PHP 5.4.1? Thanks.

------------------------------------------------------------------------
[2012-04-03 06:07:04] reeze dot xia at gmail dot com

PS:

@pierrick pull request is here https://github.com/php/php-src/pull/35.

thanks.

------------------------------------------------------------------------
[2012-04-03 05:56:12] reeze dot xia at gmail dot com

Hi, pierrick & sebastian:
   I have create another patch for this request. it differ's in:

   - rename defaultValueIsConstant to isDefaultValueConstant to match bool 
return values's is* method naming.
   - handle global constant.
   - refactor code to remove duplicate.
   - add 3 tests for it.

and I've make test everything looks fine.

please review it for me.

Thanks.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=61602


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=61602&edit=1

Thread (11 messages)

« previous php.bugs (#170445) next »