Bug #58386 [Opn->Csd]: Installation package contains two source files with non ISO file encoding

Edit report at https://bugs.php.net/bug.php?id=58386&edit=1 ID: 58386 Updated by: sixd@php.net Reported by: thiele dot nicholas at transadelaide dot sa dot gov dot au Summary: Installation package contains two source files with non ISO file encoding -Status: Open +Status: Closed Type: Bug -Package: PDO_OCI +Package: *General Issues Operating System: Solaris 5.10 PHP Version: 5.2.3 -Assigned To: +Assigned To: sixd Block user comment: N Private report: N New Comment: The PHP bundle source in git has the correct line endings. This must have been fixed some time ago. The PECL distribution is out of date and should not be used. Previous Comments: ------------------------------------------------------------------------ [2008-10-21 21:42:51] thiele dot nicholas at transadelaide dot sa dot gov dot au Description: ------------ I recently installed the PDO Abstraction Layer for Oracle following your guide at oracle.com but I noticed an issue for Unix users in that two of the files (oci_driver.c and php_pdo_oci_int.h) contained in the download (PDO_OCI-1.0.tgz) have DOS style (ASCII) line endings. The carriage return characters caused my Solaris installation to fail without a useful explanation. I extracted the compressed file and resaved these to files in the Unix format (ISO) to correct the problem. I am worried that someone without the knowledge or tools to detect and fix this issue may not be able to resolve the issue. As the rest of the files seem to be saved for Unix anyway can these two be converted with a tools such as dos2unix and re-added to the tgz file for others to download? Reproduce code: --------------- pear install PDO_OCI Expected result: ---------------- Build process completed successfully Actual result: -------------- something about and error at line 0 but the give away was the source code shown with carriage return characters (^M). ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=58386&edit=1