Bug #62496 [Opn->Nab]: OCI Session Pool Flag Incorrectly Set

Edit report at https://bugs.php.net/bug.php?id=62496&edit=1 ID: 62496 Updated by: sixd@php.net Reported by: Paul dot L dot Merchant dot Jr at dartmouth dot edu Summary: OCI Session Pool Flag Incorrectly Set -Status: Open +Status: Not a bug Type: Bug -Package: Oracle related +Package: OCI8 related Operating System: Any PHP Version: 5.4.4 Block user comment: N Private report: N New Comment: While that code could be simplified, the current effect of setting using_spool is intended. Previous Comments: ------------------------------------------------------------------------ [2012-07-06 13:47:19] Paul dot L dot Merchant dot Jr at dartmouth dot edu Description: ------------ In PHP 5.4 through 5.4.4, the oci8 source file (ext/oci/oci8.c) contains this nonsensical code in php_oci_create_session: if (!connection->using_spool) { connection->using_spool = 1; } The effect of this line is to always set the boolean using_spool to a non-zero value. I suspect that this causes a difficult to reproduce series of failures in long running server processes by causing resource cleanup to proceed incorrectly. I suspect the test should be if (!connection->private_spool) { connection->using_spool = 1; } but I'm not familiar enough with the session pooling features to be sure. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=62496&edit=1