Bug #55671 [Opn]: clean up the php 6 references in run-tests.php

Edit report at https://bugs.php.net/bug.php?id=55671&edit=1 ID: 55671 Updated by: laruence@php.net Reported by: tyrael@php.net Summary: clean up the php 6 references in run-tests.php Status: Open Type: Bug Package: Testing related PHP Version: Irrelevant Block user comment: N Private report: N New Comment: I really don't understand your point. did you read the codes carefully? it's not a php 6 specifc test, it's about to generate a warning about safe_mode. it has nothing to do with php 6. 5.2 5.3 still have safe_mode. then MAJOR_VERSOIN of them will meet that condition.. Previous Comments: ------------------------------------------------------------------------ [2012-09-09 09:31:35] reeze dot xia at gmail dot com PHP6 didn't exist so that test was useless, as tyrael said, safe_mode have been removed with 5.4. ------------------------------------------------------------------------ [2012-09-09 09:05:29] laruence@php.net "MAJOR_VERSION < 6" has nothing to do with PHP 6, what do you expected? MAJOR_VERSION <= 5? ------------------------------------------------------------------------ [2012-09-08 14:57:11] reeze dot xia at gmail dot com Do we still have the problem? I saw only one place have php6 specific test in run-tests.php if (PHP_MAJOR_VERSION < 6) { ini_set('magic_quotes_runtime',0); // this would break tests by modifying EXPECT sections if (ini_get('safe_mode')) { echo <<< SAFE_MODE_WARNING ------------------------------------------------------------------------ [2011-09-13 06:38:52] sixd@php.net A number of phpt's still have the PHP 6 syntax. These would need to be updated before the string type change is made to run-tests.php ------------------------------------------------------------------------ [2011-09-12 11:30:19] tyrael@php.net Description: ------------ there are mentions and special cases for working with php6, which isn't valid anymore. we should remove those(unicode string/binary string types), and there are some, which should be enabled for >= 504000: magic_quotes, safe_mode check, as those are removed with 5.4 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=55671&edit=1