Bug #60723 [Asn->Csd]: error_log error time has changed to UTC ignoring default timezo

From: Date: Sun, 23 Sep 2012 14:59:53 +0000
Subject: Bug #60723 [Asn->Csd]: error_log error time has changed to UTC ignoring default timezo
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-173652@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=60723&edit=1

 ID:                 60723
 Updated by:         laruence@php.net
 Reported by:        olemarkus at gentoo dot org
 Summary:            error_log error time has changed to UTC ignoring
                     default timezo
-Status:             Assigned
+Status:             Closed
 Type:               Bug
 Package:            Date/time related
 Operating System:   Gentoo Linux
 PHP Version:        5.3.9
 Assigned To:        derick
 Block user comment: N
 Private report:     N

 New Comment:

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=395d77c540a2d9d0745c8b4c75d60599c6e17c87
Log: Fixed bug #60723 (error_log error time has changed to UTC ignoring default timezo)


Previous Comments:
------------------------------------------------------------------------
[2012-09-21 12:59:26] laruence@php.net

@junk I think the format of output should be consistent. which means either all 
include the 'e', or all don't.

------------------------------------------------------------------------
[2012-09-21 12:43:44] junk at ipercolate dot net

sorry, a typo above.  I set localtime to 0 (zero) ifdev ZTS

cheers,

------------------------------------------------------------------------
[2012-09-21 11:01:44] junk at ipercolate dot net

Hi,

I don't think the existing behaviour (string format) should be changed, for most users.  I
expect there will be many shell scripts that will break slightly because the TZ is now written into
the error_time_str.   I have patched my build to only add the TZ to the string if expected behaviour
is different (ie logged time is in UTC).

I revert to original behaviour on initially setting error_time_str (localtime = 1), and then add an
'#ifdef ZTS' to set it with localtime = 1 and include 'e' in the format string.

I can add this patch file ?

cheers,

------------------------------------------------------------------------
[2012-09-21 05:16:38] laruence@php.net

yes，I have attached a patch, will
commit it later, I am not able to do a whole test now:)

------------------------------------------------------------------------
[2012-09-21 03:19:32] ramsy at ramix dot jp

laruence:
It will be a peculiar problem in ZTS. 
I think that it does not become a reason fixed to UTC in all?

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=60723


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=60723&edit=1

Thread (39 messages)

« previous php.bugs (#173652) next »