Bug #63508 [Opn]: LimitIterator should implement SeekableIterator

Edit report at https://bugs.php.net/bug.php?id=63508&edit=1 ID: 63508 Updated by: levim@php.net Reported by: levim@php.net Summary: LimitIterator should implement SeekableIterator Status: Open Type: Bug Package: SPL related PHP Version: 5.4.8 Block user comment: N Private report: N New Comment: I just noticed something: LimitIterator::seek returns int; SeekableIterator::seek returns void; When they were created they should have been made to match. That's probably why LimitIterator didn't implement SeekableIterator, though. Is this a problem? Previous Comments: ------------------------------------------------------------------------ [2012-11-13 23:08:35] levim@php.net The following patch has been added/updated: Patch Name: LimitIterator_implement_SeekableIterator Revision: 1352848115 URL: https://bugs.php.net/patch-display.php?bug=63508&patch=LimitIterator_implement_SeekableIterator&revision=1352848115 ------------------------------------------------------------------------ [2012-11-13 23:00:40] levim@php.net The following patch has been added/updated: Patch Name: LimitIterator_implement_SeekableIterator Revision: 1352847640 URL: https://bugs.php.net/patch-display.php?bug=63508&patch=LimitIterator_implement_SeekableIterator&revision=1352847640 ------------------------------------------------------------------------ [2012-11-13 23:00:18] levim@php.net Description: ------------ LimitIterator already implements SeekableIterator; it just doesn't do so formally. Test script: --------------- <?php $iterator = new LimitIterator( new ArrayIterator(array(1,2,3,4)) ); var_dump($iterator instanceof SeekableIterator); var_dump(method_exists($iterator, 'seek')); $iterator->seek(2); var_dump($iterator->current()); Expected result: ---------------- bool(true) bool(true) int(3) Actual result: -------------- bool(false) bool(true) int(3) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=63508&edit=1