Bug #48711 [Fbk->NoF]: metaphone() and sch, ch, gh

Edit report at https://bugs.php.net/bug.php?id=48711&edit=1 ID: 48711 Updated by: php-bugs@lists.php.net Reported by: brettz9 at yahoo dot com Summary: metaphone() and sch, ch, gh -Status: Feedback +Status: No Feedback Type: Bug Package: Strings related Operating System: Windows PHP Version: 5.3 Assigned To: pajoye New Comment: No feedback was provided. The bug is being suspended because we assume that you are no longer experiencing the problem. If this is not the case and you are able to provide the information that was requested earlier, please do so and change the status of the bug back to "Open". Thank you. Previous Comments: ------------------------------------------------------------------------ [2011-05-06 09:03:54] brettz9 at yahoo dot com The "traditional" flag was based on existing code (though not exposed publicly), presumably to distinguish which metaphone() algorithm was intended: the original BASIC implementation or later versions (see http://aspell.net/metaphone/)/PHP's own innovations. ------------------------------------------------------------------------ [2011-02-26 20:24:15] jthijssen at noxlogic dot nl Pierre, I've added a phpt testcase inside the patch (bug48711.phpt). Or do you mean a phpt for the extra metaphone parameter (probably a metaphone_variation.phpt)? ------------------------------------------------------------------------ [2011-02-26 20:18:33] pajoye@php.net hi, Thanks for the patch! Can you add a test case for it please? ------------------------------------------------------------------------ [2011-02-26 19:54:08] jthijssen at noxlogic dot nl I've added a patch with the 4 items as described by brettz9. The first one introduces a "traditional" boolean flag in metaphone as a third optional parameter. I'm not 100% sure why this parameter is here. Either we should always convert CHR/SCH to X or to K. It makes the function much more complicated this way for end-users. ------------------------------------------------------------------------ [2009-08-03 01:00:02] php-bugs at lists dot php dot net No feedback was provided for this bug for over a week, so it is being suspended automatically. If you are able to provide the information that was originally requested, please do so and change the status of the bug back to "Open". ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=48711 -- Edit this bug report at https://bugs.php.net/bug.php?id=48711&edit=1