Bug #64725 [NEW]: Wrong return value logic in imageaffinematrixget

From: Date: Fri, 26 Apr 2013 16:08:34 +0000
Subject: Bug #64725 [NEW]: Wrong return value logic in imageaffinematrixget
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-178656@lists.php.net to get a copy of this message 
From:             sixd
Operating system: Linux
PHP version:      5.5Git-2013-04-26 (Git)
Package:          GD related
Bug Type:         Bug
Bug description:Wrong return value logic in imageaffinematrixget

Description:
------------
Compile warnings in gd.c show that that the return value logic for
imageaffinematrixget is wrong:

/home/cjones/php-5.5/ext/gd/libgd/gd.c: In function
‘gdImagePaletteToTrueColor’:
/home/cjones/php-5.5/ext/gd/libgd/gd.c:3014: warning: unused variable
‘alloc_y’
/home/cjones/php-5.5/ext/gd/gd.c: In function
‘zif_imageaffinematrixget’:
/home/cjones/php-5.5/ext/gd/gd.c:5579: warning: suggest parentheses around
assignment used as truth value

The code it points to is:

	if (res = GD_FALSE) {
		RETURN_FALSE;
	} else {



-- 
Edit bug report at https://bugs.php.net/bug.php?id=64725&edit=1
-- 
Try a snapshot (PHP 5.4):   https://bugs.php.net/fix.php?id=64725&r=trysnapshot54
Try a snapshot (PHP 5.3):   https://bugs.php.net/fix.php?id=64725&r=trysnapshot53
Try a snapshot (trunk):     https://bugs.php.net/fix.php?id=64725&r=trysnapshottrunk
Fixed in SVN:               https://bugs.php.net/fix.php?id=64725&r=fixed
Fixed in release:           https://bugs.php.net/fix.php?id=64725&r=alreadyfixed
Need backtrace:             https://bugs.php.net/fix.php?id=64725&r=needtrace
Need Reproduce Script:      https://bugs.php.net/fix.php?id=64725&r=needscript
Try newer version:          https://bugs.php.net/fix.php?id=64725&r=oldversion
Not developer issue:        https://bugs.php.net/fix.php?id=64725&r=support
Expected behavior:          https://bugs.php.net/fix.php?id=64725&r=notwrong
Not enough info:            https://bugs.php.net/fix.php?id=64725&r=notenoughinfo
Submitted twice:            https://bugs.php.net/fix.php?id=64725&r=submittedtwice
register_globals:           https://bugs.php.net/fix.php?id=64725&r=globals
PHP 4 support discontinued: https://bugs.php.net/fix.php?id=64725&r=php4
Daylight Savings:           https://bugs.php.net/fix.php?id=64725&r=dst
IIS Stability:              https://bugs.php.net/fix.php?id=64725&r=isapi
Install GNU Sed:            https://bugs.php.net/fix.php?id=64725&r=gnused
Floating point limitations: https://bugs.php.net/fix.php?id=64725&r=float
No Zend Extensions:         https://bugs.php.net/fix.php?id=64725&r=nozend
MySQL Configuration Error:  https://bugs.php.net/fix.php?id=64725&r=mysqlcfg

Thread (3 messages)

« previous php.bugs (#178656) next »