Req #63911 [Com]: Ignore conflicting trait methods originationg from identical sub traits
| From: | simon at simon dot geek dot nz | Date: | Fri, 03 May 2013 10:26:44 +0000 |
| Subject: | Req #63911 [Com]: Ignore conflicting trait methods originationg from identical sub traits | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-178770@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=63911&edit=1
ID: 63911
Comment by: simon at simon dot geek dot nz
Reported by: bitluni at bitluni dot net
Summary: Ignore conflicting trait methods originationg from
identical sub traits
Status: Open
Type: Feature/Change Request
Package: Class/Object related
Operating System: debian
PHP Version: 5.4.10
Block user comment: N
Private report: N
New Comment:
This is still occurring with PHP 5.5, commit
cbe2870b72c4cfdb5c295e83c88d7cff5c39e396 (Fri May 3 12:25:49 2013 +0400).
Not being able to use multiple traits that have the same trait somewhere in their
composition trees is a rather major limitation of the trait system.
Previous Comments:
------------------------------------------------------------------------
[2013-01-06 10:31:40] bitluni at bitluni dot net
@necktrox
I know there is 'insteadof' but see my example, there is just one function implemented yet
still I get collision error. The traits are just usable very flat at the moment. If you have an
hirachical stucture of traits like I do, you have to do potentally exponetial count of
'insteadof's in the top level class even there's not one dublicate function
implemented.
------------------------------------------------------------------------
[2013-01-06 02:36:02] necktrox at gmail dot com
# from http://php.net/manual/de/language.oop5.traits.php
trait A {
public function smallTalk() {
echo 'a';
}
public function bigTalk() {
echo 'A';
}
}
trait B {
public function smallTalk() {
echo 'b';
}
public function bigTalk() {
echo 'B';
}
}
class Talker {
use A, B {
B::smallTalk insteadof A;
A::bigTalk insteadof B;
}
}
------------------------------------------------------------------------
[2013-01-05 18:39:11] bitluni at bitluni dot net
same issue for properties
------------------------------------------------------------------------
[2013-01-05 18:27:56] bitluni at bitluni dot net
Description:
------------
When extracting traits I would like to extract some general functions into sub traits and
'use' them in the traits where needed.
But when I compose a class out of multiple traits with sub traits I have to do obsolete statements
regardless if the colliding methods originate from same sub trait.
Just add a check if a method collides with itself
Test script:
---------------
trait A
{
public function a(){}
}
trait B
{
use A;
}
trait C
{
use A;
}
class D
{
use B, C;
}
Actual result:
--------------
Fatal error: Trait method a has not been applied, because there are collisions with other trait
methods on D in
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=63911&edit=1