Bug #64989 [Opn]: more accurate return value for readdir()

Edit report at https://bugs.php.net/bug.php?id=64989&edit=1 ID: 64989 User updated by: vosa at binaryparadise dot com Reported by: vosa at binaryparadise dot com Summary: more accurate return value for readdir() Status: Open Type: Bug Package: Filesystem function related Operating System: linux PHP Version: Irrelevant Block user comment: N Private report: N New Comment: Sorry for bad example in original message. Correct one: while(FALSE !== readdir('definitely_not_handler')); Previous Comments: ------------------------------------------------------------------------ [2013-06-07 15:08:40] vosa at binaryparadise dot com Description: ------------ --- From manual page: http://www.php.net/function.readdir#refsect1-function.readdir-examples --- From documentation: "Returns the entry name on success or FALSE on failure." Function returns NULL instead of FALSE in case of bad dir_handler. I think it should be mentioned in documentation at least. If dir_handler is not exactly resource, then i.e.: "while(FALSE === readdir('definitely_not_handler'));" can end very badly. Test script: --------------- var_dump(readdir('definitely_not_handler')); Expected result: ---------------- FALSE Actual result: -------------- NULL ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=64989&edit=1