Bug #65047 [Com]: Test skip on client / server version

Edit report at https://bugs.php.net/bug.php?id=65047&edit=1 ID: 65047 Comment by: remi@php.net Reported by: remi@php.net Summary: Test skip on client / server version Status: Open Type: Bug Package: PostgreSQL related Operating System: GNU/Linux PHP Version: 5.4.16 Block user comment: N Private report: N New Comment: On a opposite side pgsql/tests/bug37100.phpt could use skip_client_version('8.5dev', '>='); It will be run and will succeed with client version 8.4 Previous Comments: ------------------------------------------------------------------------ [2013-06-17 13:11:33] remi@php.net Description: ------------ Hi, Running the php test suite, using a client library version 8.4.13 (RHEL-6) against a server running version 9.2.4 (RHEL-6 + RHSCL 1.0beta) reports some failures /tmp/php-5.4.16/ext/pgsql/tests/08escape.phpt /tmp/php-5.4.16/ext/pgsql/tests/10pg_convert_85.phpt /tmp/php-5.4.16/ext/pgsql/tests/12pg_insert_85.phpt /tmp/php-5.4.16/ext/pgsql/tests/14pg_update_85.phpt /tmp/php-5.4.16/ext/pgsql/tests/18pg_escape_bytea.phpt /tmp/php-5.4.16/ext/pgsql/tests/bug37100_85.phpt /tmp/php-5.4.16/ext/pdo_pgsql/tests/bug46274.phpt /tmp/php-5.4.16/ext/pdo_pgsql/tests/bug46274_2.phpt For example PQunescapeBytea function is a pure client side function. So result depends on the client version, not on the server version. Proposal, keep (or add where is missing): skip_server_version('8.5dev', '<'); And add: skip_client_version('8.5dev', '<'); I agree, using a 8.4 client to access a 9.2 server is something which should be avoid... What is your thoughts ? (I prefer asking before committing something perhaps stupid) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=65047&edit=1