Bug #65268 [Asn->Csd]: select() implementation uses outdated tick API
| From: | ab@php.net | Date: | Thu, 18 Jul 2013 16:44:25 +0000 |
| Subject: | Bug #65268 [Asn->Csd]: select() implementation uses outdated tick API | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-180326@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=65268&edit=1
ID: 65268
Updated by: ab@php.net
Reported by: ab@php.net
Summary: select() implementation uses outdated tick API
-Status: Assigned
+Status: Closed
Type: Bug
Package: Streams related
Operating System: windows
PHP Version: 5.5Git-2013-07-16 (Git)
Assigned To: ab
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=99afc6dc11016be47ce2ba09779ae4a34d435f5b
Log: Fixed bug #65268 select() implementation uses outdated tick API
Previous Comments:
------------------------------------------------------------------------
[2013-07-16 10:40:01] ab@php.net
Description:
------------
The implementation of php_select() in win32/select.c uses outdated function Get
TickCount. From the documentation page http://msdn.microsoft.com/en-
us/library/ms724408(v=vs.85).aspx
"The elapsed time is stored as a DWORD value. Therefore, the time will wrap around
to zero if the system is run continuously for 49.7 days. To avoid this problem,
use the GetTickCount64 function. Otherwise, check for an overflow condition when
comparing times."
This can be an issue for long running php processes. As 5.5 has not to support
windows xp anymore, and as the documentation suggests, GetTickCount64 should be
used.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=65268&edit=1