Bug #65562 [Fbk->Opn]: memory leak in zend_parse_arg

Edit report at https://bugs.php.net/bug.php?id=65562&edit=1 ID: 65562 Updated by: johannes@php.net Reported by: rrh at newrelic dot com Summary: memory leak in zend_parse_arg -Status: Feedback +Status: Open Type: Bug Package: Performance problem Operating System: all PHP Version: 5.5.3 Block user comment: N Private report: N New Comment: A cleaner patch might pass the quiet argument to zend_parse_arg_impl, this would safe the allocation in there. This also seems to be limited to C and f modifiers which, in PHP itself, aren't used in combination with ZEND_PARSE_PARAMS_QUIET. So for adding a test we might need a deug-build-only functionin zend_builtin_functions.c. This might need coordination with docs and their function detection scripts. And sorry if I'm a bit harsh, but 99% of the internal API bugs we get are user errors and this bug was sparse on information. Previous Comments: ------------------------------------------------------------------------ [2013-08-26 23:14:26] sixd@php.net Waiting feedback on the patch ------------------------------------------------------------------------ [2013-08-26 23:07:33] rrh at newrelic dot com I will test the patch, and in the future come up with patches for your review. ------------------------------------------------------------------------ [2013-08-26 23:02:38] yohgaki@php.net I suspect you have pointer issue. Valgrind does not handle ***(pointer to pointer to pointer) well. Check your hash handling code carefully, it may help. ------------------------------------------------------------------------ [2013-08-26 23:02:10] johannes@php.net meant to write "your problem" :-) ------------------------------------------------------------------------ [2013-08-26 23:01:42] johannes@php.net https://github.com/johannes/php-src/commit/3bfe148c83d6c9b4134ac4fc5f6e0ae36f3f2c42 This might fix your issue. As you won't be telling whether this is our problem I can't properly test it. I'd welcome if you could test it and in future help providing patches. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=65562 -- Edit this bug report at https://bugs.php.net/bug.php?id=65562&edit=1