Req #61759 [Opn]: class_alias() should accept classes with leading backslashes

Edit report at https://bugs.php.net/bug.php?id=61759&edit=1 ID: 61759 Updated by: johannes@php.net Reported by: aharvey@php.net Summary: class_alias() should accept classes with leading backslashes Status: Open Type: Feature/Change Request Package: Class/Object related Operating System: Irrelevant PHP Version: master-Git-2012-04-18 (Git) Block user comment: N Private report: N New Comment: Technically we could, but it adds some inconsistency if one place allows this but others not and that should be avoided. Previous Comments: ------------------------------------------------------------------------ [2013-08-27 09:46:53] jpauli@php.net The following patch has been added/updated: Patch Name: fix-class_alias Revision: 1377596813 URL: https://bugs.php.net/patch-display.php?bug=61759&patch=fix-class_alias&revision=1377596813 ------------------------------------------------------------------------ [2013-08-27 09:45:12] jpauli@php.net Johannes: I agree, but we could start by patching this bug report right? I got a patch here : https://github.com/jpauli/php- src/compare/class_alias_registration_fix ------------------------------------------------------------------------ [2013-08-26 18:32:26] johannes@php.net Note: The bug report is too restrictive. A proper patch would have to work on all places where classnames come from string context. This at first means verifying that all places go via zend_lookup_class() and related functions, not EG(class_table) / CG(class_table) ------------------------------------------------------------------------ [2013-08-26 18:13:08] contact at jubianchi dot fr I experienced the exact same issue on PHP 5.4.17 on OS X 10.9 (Mavericks DP6). I wrote a simple test case, here it is : Test script: --------------- namespace jubianchi\Alias { class A {} var_dump(class_alias('\\jubianchi\\Alias\\A', 'C')); $reflector = new \ReflectionClass('C'); var_dump($reflector->getName()); var_dump(class_alias('\\jubianchi\\Alias\\A', '\\jubianchi\\Alias\\B')); try { $reflector = new \ReflectionClass('\\jubianchi\\Alias\\B'); var_dump($reflector->getName()); } catch(\Exception $e) { var_dump(get_class($e) . ': ' . $e->getMessage()); } var_dump(class_alias('\\jubianchi\\Alias\\A', 'jubianchi\\Alias\\B')); $reflector = new \ReflectionClass('\\jubianchi\\Alias\\B'); var_dump($reflector->getName()); } Expected result: ---------------- bool(true) string(17) "jubianchi\Alias\A" bool(true) string(17) "jubianchi\Alias\A" bool(true) string(17) "jubianchi\Alias\A" Or: ---------------- bool(true) string(17) "jubianchi\Alias\A" bool(false) string(60) "ReflectionException: Class \jubianchi\Alias\B does not exist" bool(true) string(17) "jubianchi\Alias\A" Actual result: ---------------- bool(true) string(1) "A" bool(true) string(17) "jubianchi\Alias\A" bool(true) string(60) "ReflectionException: Class \jubianchi\Alias\B does not exist" bool(true) string(17) "jubianchi\Alias\A" As you can see, class_alias returns bool(true) as if everything went fine, so we expect the alias to be available but a reflection on the latter throws an exception. I think class_alias should be able to handle the leading backslashes or return bool(false) if it can't. ------------------------------------------------------------------------ [2012-04-18 06:11:21] aharvey@php.net Description: ------------ Aliasing namespaced classes currently expects that class names will be given in the same form as the ZE uses internally; ie without a leading backslash. Since that's inconsistent with the absolute form in PHP, it would be good if class_alias() could also ignore a leading backslash. Test script: --------------- <?php namespace A; class C { function foo() { echo "42\n"; } } namespace B; class_alias('\A\C', '\B\C'); $c = new C; $c->foo(); Expected result: ---------------- 42 Actual result: -------------- Fatal error: Class 'B\C' not found in /private/tmp/test.php on line 7 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=61759&edit=1