Bug #64396 [Fbk->Csd]: tests/basic/req60524.phpt should not be run on Windows
Edit report at https://bugs.php.net/bug.php?id=64396&edit=1
ID: 64396
Updated by: mattficken@php.net
Reported by: mattficken@php.net
Summary: tests/basic/req60524.phpt should not be run on
Windows
-Status: Feedback
+Status: Closed
Type: Bug
Package: *Directory/Filesystem functions
Operating System: Windows
PHP Version: 5.5.0alpha5
Assigned To: mattficken
Block user comment: N
Private report: N
Previous Comments:
------------------------------------------------------------------------
[2013-09-03 16:42:38] mattficken@php.net
Yes I committed it, but forgot to close this bug report.
------------------------------------------------------------------------
[2013-09-01 01:16:18] pajoye@php.net
Matt? Did you apply it?
------------------------------------------------------------------------
[2013-03-22 06:30:41] pajoye@php.net
Please duplicate the test and commit it :)
------------------------------------------------------------------------
[2013-03-21 22:55:39] mattficken@php.net
The point of this test is to test the new sys_temp_dir directive to make sure that the directive
value is returned by sys_get_temp_dir. The point of the directive is to enable using different
INI files to get sys_get_temp_dir to return different temp dirs (for virtual hosts).
Directives have to be set in the INI section. The PHPT format doesn't provide a way to have
different INI sections for Windows or *nix.
Therefore there needs to be a separate -win32 fork for this test, which is what the original patch
does.
------------------------------------------------------------------------
[2013-03-09 01:07:45] pajoye@php.net
Thanks for the patch!
I would modify the test to compare the string result instead and output OK when it
matches. Doing so will avoid to create a windows only version of this test (which
basically test the ini setting). Feel free to commit it once you are done :)
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=64396
--
Edit this bug report at https://bugs.php.net/bug.php?id=64396&edit=1
Thread (7 messages)