Req #60760 [Com]: Converting zend_parse_parameters() to zend_parse_parameters_none()

Edit report at https://bugs.php.net/bug.php?id=60760&edit=1 ID: 60760 Comment by: levim@php.net Reported by: dragoonis@php.net Summary: Converting zend_parse_parameters() to zend_parse_parameters_none() Status: Assigned Type: Feature/Change Request Package: SPL related Operating System: N/A PHP Version: 5 Assigned To: levim Block user comment: N Private report: N New Comment: The latest patch follows the convention: zend_parse_parameters_none() == FAILURE It also converts a few zpp that are not 'none': FAILURE == zend_parse_parameters(...) zend_parse_parameters(...) == FAILURE Previous Comments: ------------------------------------------------------------------------ [2013-09-18 15:00:33] levim@php.net The following patch has been added/updated: Patch Name: spl_zpp_none.diff Revision: 1379516433 URL: https://bugs.php.net/patch-display.php?bug=60760&patch=spl_zpp_none.diff&revision=1379516433 ------------------------------------------------------------------------ [2013-09-18 09:39:20] nikic@php.net @levi You should use the == FAILURE variant. Nearly all PHP code does the failure/success comparison at the end :) ------------------------------------------------------------------------ [2013-09-17 23:58:15] levim@php.net My latest patch changes a few of these. Also, there were two styles in use: if (zend_parse_parameters_none() == FAILURE) if (FAILURE == zend_parse_parameters_none()) I picked the latter as if (FAILURE indicates the purpose a bit better, in my opinion. If I should have picked the former: let me know and I'll attach a new patch. ------------------------------------------------------------------------ [2013-09-17 23:55:45] levim@php.net The following patch has been added/updated: Patch Name: spl_zpp_none.patch Revision: 1379462145 URL: https://bugs.php.net/patch-display.php?bug=60760&patch=spl_zpp_none.patch&revision=1379462145 ------------------------------------------------------------------------ [2012-01-20 02:37:31] dragoonis@php.net This is just the way a lot of the phpsrc has been built. Look around various /ext/ places and you'll see it. I'm just cleaning things up and keeping consistency. Got a few more cleanup patches to submit on the SplHeap class for this same reason as i've been working on that class recently. - Paul. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=60760 -- Edit this bug report at https://bugs.php.net/bug.php?id=60760&edit=1