Bug #64874 [Com]: json_decode handles whitespace and case-sensitivity incorrectly

Edit report at https://bugs.php.net/bug.php?id=64874&edit=1 ID: 64874 Comment by: ajf at ajf dot me Reported by: chrivers at iversen-net dot dk Summary: json_decode handles whitespace and case-sensitivity incorrectly Status: Open Type: Bug Package: JSON related Operating System: All PHP Version: 5.4.15 Block user comment: N Private report: N New Comment: My request to fix the whitespace portion of this bug was merged into the PHP-5.4 branch (and hence will be in the next minor 5.4 and 5.5 releases). Now I simply need to try and get the case fix bit into 5.6 (it breaks BC so it can't be in 5.4 or 5.5, I bet): https://github.com/php/php-src/pull/457 Previous Comments: ------------------------------------------------------------------------ [2013-10-16 12:27:25] ajf at ajf dot me The pull request to fix the bug was split into two parts. The first is the backwards-compatible part (whitespace fix), which should go into 5.4 and 5.5: https://github.com/php/php-src/pull/456 The second is to fix the non-backwards-compatible part (case), which should go into 5.6: https://github.com/php/php-src/pull/457 ------------------------------------------------------------------------ [2013-09-11 10:38:41] ajf at ajf dot me Submitted pull request: https://github.com/php/php-src/pull/436 ------------------------------------------------------------------------ [2013-09-09 17:05:34] cmbecker69 at gmx dot de There is a RFC[1] to replace the current JSON implementation with the jsonc PECL extension, so "fixing" that implementation may not be reasonable anyway. [1] <https://wiki.php.net/rfc/free-json-parser> ------------------------------------------------------------------------ [2013-09-09 16:24:12] ajf at ajf dot me D:\Projects>php -r "var_dump(json_decode('tRUe'));" bool(true) Seems to still be broken, I'll try to fix it. ------------------------------------------------------------------------ [2013-05-19 20:04:53] chrivers at iversen-net dot dk Well, the part of the RFC that you're quoting describes the "JSON-text" type, which indeed must be non- primitive. However, the json_decode() function is documented as taking a "json value", which according to the spec is """ A JSON value MUST be an object, array, number, or string, or one of the following three literal names: false null true """ So that's perfectly fine, really. There are other errors, too. For example, " true" WORKS while "true " fails, which makes no sense at all. I've created an updated test case: <? $fmt = "%-12s %-20s %-20s %-10s %-5s\n"; function json_cmp($x, $y) { global $fmt; $error = array("-", "FAIL"); printf($fmt, var_export($x, true), str_replace("\n", "", var_export($y, true)), str_replace("\n", "", var_export(json_decode($x), true)), $error[json_last_error() > 0], $error[json_decode($x) !== $y] ); } printf($fmt, "JSON", "Expected", "Actual", "JSON_ERROR", "PASS"); printf("---------------------------------------------------------------------- \n"); // works json_cmp("true", true); // fails - is actually true json_cmp("tRue", NULL); // fails - is actually NULL json_cmp("true ", true); // works json_cmp("[true ] ", array(true)); json_cmp("[ true ] ", array(true)); json_cmp("[true] ", array(true)); // works, even though the non-array version fails json_cmp("[tRue]", NULL); json_cmp("0", 0); json_cmp("1", 1); json_cmp("false", false); json_cmp("'foo'", NULL); json_cmp('"foo"', "foo"); json_cmp('1.123', 1.123); json_cmp('1.123 ', 1.123); json_cmp(' 1.123', 1.123); json_cmp('42', 42); json_cmp('42 ', 42); json_cmp(' 42', 42); json_cmp(".123", 0.123); ?> Which gives the following results: JSON Expected Actual JSON_ERROR PASS ---------------------------------------------------------------------- 'true' true true - - 'tRue' NULL true - FAIL 'true ' true NULL FAIL FAIL '[true ] ' array ( 0 => true,) array ( 0 => true,) - - '[ true ] ' array ( 0 => true,) array ( 0 => true,) - - '[true] ' array ( 0 => true,) array ( 0 => true,) - - '[tRue]' NULL NULL FAIL - '0' 0 0 - - '1' 1 1 - - 'false' false false - - '\'foo\'' NULL NULL FAIL - '"foo"' 'foo' 'foo' - - '1.123' 1.123 1.123 - - '1.123 ' 1.123 NULL FAIL FAIL ' 1.123' 1.123 1.123 - - '42' 42 42 - - '42 ' 42 NULL FAIL FAIL ' 42' 42 42 - - '.123' 0.123 0.123 - - I see "FAIL" 4 times, so that seems like 4 bugs to me. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=64874 -- Edit this bug report at https://bugs.php.net/bug.php?id=64874&edit=1