Bug #66298 [Csd]: ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend

From: Date: Mon, 30 Dec 2013 03:12:28 +0000
Subject: Bug #66298 [Csd]: ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-183492@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=66298&edit=1

 ID:                 66298
 Updated by:         laruence@php.net
 Reported by:        dam at opencsw dot org
 Summary:            ext/opcache/Optimizer/zend_optimizer.c has dos-style
                     ^M as lineend
 Status:             Closed
 Type:               Bug
 Package:            opcache
 Operating System:   Solaris
 PHP Version:        5.5.7
 Assigned To:        laruence
 Block user comment: N
 Private report:     N

 New Comment:

@krakjoe okey, fixed, thanks


Previous Comments:
------------------------------------------------------------------------
[2013-12-30 02:54:09] laruence@php.net

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=a88543a106fa2e43b3153d11987b577ec28f78c0
Log: Fixed bug #66298 (ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend)

------------------------------------------------------------------------
[2013-12-30 02:54:07] laruence@php.net

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=04c8ce259fb422c7bcdac3d72bacbf0ee910d772
Log: Fixed bug #66298 (ext/opcache/Optimizer/zend_optimizer.c has dos-style ^M as lineend)

------------------------------------------------------------------------
[2013-12-29 20:07:58] krakjoe@php.net

I assume this actually breaks opcache for Solaris, so is this fixed yet or what ?

Laruence, assigning to you to get some attention again, I think history is not important if the
build (or opcache) is broken.

------------------------------------------------------------------------
[2013-12-16 07:53:45] laruence@php.net

fixing this is simple. but it is difficult to keep previous commit history (I mean don't break
git blame result) :<

------------------------------------------------------------------------
[2013-12-15 18:04:37] dam at opencsw dot org

Description:
------------
The file
  ext/opcache/Optimizer/zend_optimizer.c
has DOS ^M lineend. On Solaris this leads macros with line continuations \ to not work any more.



------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=66298&edit=1

Thread (7 messages)

« previous php.bugs (#183492) next »