Bug #66471 [Asn->Csd]: #if changes to comment out PHP-5.6 functionality for 5.5 and earlier builds
Edit report at https://bugs.php.net/bug.php?id=66471&edit=1
ID: 66471
Updated by: dmitry@php.net
Reported by: Terry at ellisons dot org dot uk
Summary: #if changes to comment out PHP-5.6 functionality for
5.5 and earlier builds
-Status: Assigned
+Status: Closed
Type: Bug
Package: opcache
Operating System: N/A
PHP Version: master-Git-2014-01-12 (Git)
Assigned To: dmitry
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of dmitry@zend.com
Revision: http://git.php.net/?p=php-src.git;a=commit;h=ca550248f18c842c22f3db880b8ea66c553da343
Log: Fixed bug #66471 (Keep backward compatibility)
Previous Comments:
------------------------------------------------------------------------
[2014-01-13 10:07:30] dmitry@php.net
Terry,
The patch you proposes is not for PHP-5.6. We don't have orig_interned_empty_string there (and
never had it).
The #if condition for zend_virtual_cwd.h selection is wrong.
Anyway, I understood you idea and it may have sense.
------------------------------------------------------------------------
[2014-01-12 13:52:21] Terry at ellisons dot org dot uk
Description:
------------
As discussed in https://github.com/zendtech/ZendOptimizerPlus/issues/157
any enhancements to OPcache which depend on PHP-5.6-specific Zend engine changes should have the
appropriate conditional compile guards to allow a common code base to be used with the ZendOpcache
PECL extension.
Since I've done this merge, I am just posting this changes for your convenience.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=66471&edit=1
Thread (6 messages)