Bug #66066 [Opn]: opcache_compile_file partially execute file and output errors

From: Date: Tue, 14 Jan 2014 10:55:32 +0000
Subject: Bug #66066 [Opn]: opcache_compile_file partially execute file and output errors
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-183784@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=66066&edit=1

 ID:                 66066
 User updated by:    geompse at gmail dot com
 Reported by:        geompse at gmail dot com
 Summary:            opcache_compile_file partially execute file and
                     output errors
 Status:             Open
 Type:               Bug
 Package:            opcache
 Operating System:   Debian 3.8.13
 PHP Version:        5.5.5
 Block user comment: N
 Private report:     N

 New Comment:

There is an issue, something is not doing what it say it does.
There are obvious solutions :
- make it not do that (= let it do it silently)
- say it does what it does (= update documentation)
- add option to handle it cleanly (= add boolean somewhere and use it)
There are more specific solutions :
- cleanup the whole PHP "Zend" code :)
- make OPCache run in a different context (nb : not only a different scope)
- other...

You are telling me that this is not a bug (undocumented behavior is expected) and that instead of
using the bug report system (bugs.php.net) I must talk with the StackOverflow community to convince
them of telling you this is a bug ?
I won't. You may not solve this bug and let other PHP developers get in troubles.

I filled in this report for the PHP community. Live long and prosper.


Previous Comments:
------------------------------------------------------------------------
[2014-01-13 14:31:50] Terry at ellisons dot org dot uk

Geompse, this may be counter-intuitive behaviour, but this is PHP that we're talking about here
:-)  What you are trying to do is hitting artefacts of Zend engine constraints rather than OPcache
ones.  You will get into just the same sort of problems if you try to do an include __FILE__; if
your file embeds statically declared functions or classes.   

The PHP bugrep system is a poor place to have this discussion.  Why not post a Q to StackOverflow
explaining what you are trying to do, and we can have the discussion on a forum more suited to this?
 If we distill out of that some specific issue that needs raising here, then there is more chance of
it getting actioned that way.  Terry

------------------------------------------------------------------------
[2014-01-13 03:18:47] geompse at gmail dot com

Terry,

This may not be a "logical bug" but it is at least an undocumented behavior.
To me, this is very misleading ("Fatal error" not fatal for the current script).

Plus, combined with exception_handler this will do "weird shit".

>> There should be an optional argument or configuration to disable both errors, or
>> compile-scope error(s).

See practical use, framework is designed for production usage.
All errors are e-mailed, db-stored and eventually displayed. Any error is fatal (die).

The function is doing what the documentation says it does. But it is doing more than that. Please
correct either the function ("bug") or the documentation ("documentation
problem").

Cordialement,
Geompse

------------------------------------------------------------------------
[2014-01-12 15:57:23] Terry at ellisons dot org dot uk

This is "Not a bug".  

What you are describing is the behaviour that we'd expect with PHP and OPcache, so why is it a
bug? EG(function_table) already contains an entry for function coucou, so compiling any script with
coucou in it will result in a "Cannot redeclare" error being thrown.

------------------------------------------------------------------------
[2013-11-08 16:18:00] geompse at gmail dot com

Description:
------------
---
From manual page: http://www.php.net/function.opcache-compile-file
"Compiles and caches a PHP script without executing it"
---

As the documentation says, the script should not be executed (and it is not).
But when trying to compile the current file, or an already included/required file, the function
generate a Fatal Error and a Warning (wich can both by visually suppressed when using
"@").

Practical use : updater script
- overwrite files with new ones
- force opcache recompilation
The update is in the framework, and updates the framework. All already-included classes are already
defined, and thus the compilation fail (or seems to fail, anyways it reports a failure).

Test script:
---------------
<?php

error_reporting(E_ALL);
ini_set('display_errors','On');

function coucou()
{
}

echo 'Before'."\n";
opcache_compile_file(__FILE__);
echo 'After'."\n";

?>


Expected result:
----------------
Before
After


Actual result:
--------------
Before

Fatal error: Cannot redeclare coucou() (previously declared in /root/compile.php:8) in
/root/compile.php on line 8

Warning: Zend OPcache could not compile file /root/compile.php in Unknown on line 0
After



------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=66066&edit=1


Thread (9 messages)

« previous php.bugs (#183784) next »