Bug #66091 [Nab->Asn]: Memory leak in DateTime::createFromFormat()

Edit report at https://bugs.php.net/bug.php?id=66091&edit=1 ID: 66091 Updated by: ab@php.net Reported by: lars_teuber at gmx dot de Summary: Memory leak in DateTime::createFromFormat() -Status: Not a bug +Status: Assigned Type: Bug Package: Unknown/Other Function Operating System: Windows/Linux PHP Version: Irrelevant Assigned To: ab Block user comment: N Private report: N New Comment: @nikic, now looking at the code of date_load_from_format i think you're right. In case it has to RETURN_FALSE a leak is possible. I will check that, thanks. Previous Comments: ------------------------------------------------------------------------ [2014-04-05 19:53:08] nikic@php.net @ab: If you don't use the return value of a function call, it will be immidiately destroyed. As such there should be no difference between ignoring the return value and doing an assing+unset. To me this looks like we're indeed leaking something. ------------------------------------------------------------------------ [2014-04-05 17:03:46] ab@php.net Thank you for taking the time to write to us, but this is not a bug. Please double-check the documentation available at http://www.php.net/manual/ and the instructions on how to report a bug at http://bugs.php.net/how-to-report.php so marking as nab ------------------------------------------------------------------------ [2014-04-05 17:03:04] ab@php.net But in your code, you just continuously create new objects. It is then logic that the memory is cluttered up. Try using the return value and then explicitly unset() it. ------------------------------------------------------------------------ [2013-11-13 17:01:03] lars_teuber at gmx dot de Description: ------------ Hi, DateTime::createFromFormat() has a memory leak. Tested with: 5.3.14, 5.4.4, 5.5.3 Best regards Lars Teuber Test script: --------------- <?php $mem_start = memory_get_usage(true); echo 'start: ' . $mem_start . '<br>'; $max_iterations = 1000000; for ($i = 1; $i <= $max_iterations; $i++) { DateTime::createFromFormat('M/D/Y H:i:s', '2013-11-12 20:00:00'); if (($i % 100000) == 0) { echo $i . '.: ' . memory_get_usage(true) . '<br>'; } } $mem_end = memory_get_usage(true); echo 'end: ' . $mem_end . '<br>'; echo 'diff end-start: ' . ($mem_end - $mem_start) . '<br>'; ?> Expected result: ---------------- (more or less) constant memory usage Actual result: -------------- start: 524288 100000.: 16777216 200000.: 33030144 300000.: 53477376 400000.: 65536000 500000.: 77594624 600000.: 106168320 700000.: 118226944 800000.: 130285568 900000.: 142344192 1000000.: 154140672 end: 154140672 diff end-start: 153616384 ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=66091&edit=1