Bug #66595 [Csd]: apache2filter was neglected

From: Date: Thu, 10 Apr 2014 04:00:57 +0000
Subject: Bug #66595 [Csd]: apache2filter was neglected
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-185159@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=66595&edit=1

 ID:                 66595
 Updated by:         tyrael@php.net
 Reported by:        ondrej@php.net
 Summary:            apache2filter was neglected
 Status:             Closed
 Type:               Bug
 Package:            Compile Failure
 PHP Version:        5.6.0alpha1
 Assigned To:        mike
 Block user comment: N
 Private report:     N

 New Comment:

thanks!
I can feel your pain, but as long as we have this SAPI in the core, we have to support it.
Make sure we don't forget discussing the removal of the old SAPIs when kicking off the next
major.


Previous Comments:
------------------------------------------------------------------------
[2014-03-24 16:55:28] mike@php.net

Felt like like a lot of wasted time:
http://git.php.net/?p=php-src.git;a=commit;h=275b2c420dfdd6056e465d6be2256a94227c9df5

------------------------------------------------------------------------
[2014-01-29 08:33:37] tyrael@php.net

Mike, could you look into this please?

------------------------------------------------------------------------
[2014-01-28 12:12:16] ondrej@php.net

Description:
------------
Apparently nobody has tested apache2filter SAPI when doing 5.6.0alpha1 release, so it doesn't
build since sapi_request_info *post_data* has been removed.

Unfortunately this is beyond my PHP internals knowledge, so somebody else needs to fix this.

Expected result:
----------------
apache2filter compiled

Actual result:
--------------
/tmp/buildd/php5-5.6.0~alpha1+dfsg/sapi/apache2filter/sapi_apache2.c: In function
'php_apache_request_ctor':
/tmp/buildd/php5-5.6.0~alpha1+dfsg/sapi/apache2filter/sapi_apache2.c:416:18: error:
'sapi_request_info' has no member named 'post_data'
  SG(request_info).post_data = ctx->post_data;
                  ^
/tmp/buildd/php5-5.6.0~alpha1+dfsg/sapi/apache2filter/sapi_apache2.c:417:18: error:
'sapi_request_info' has no member named 'post_data_length'
  SG(request_info).post_data_length = ctx->post_len;
                  ^



------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=66595&edit=1

Thread (4 messages)

« previous php.bugs (#185159) next »