Bug #66714 [Opn->Csd]: imageconvolution processing output inconsistent with previous versions

Edit report at https://bugs.php.net/bug.php?id=66714&edit=1 ID: 66714 Updated by: stas@php.net Reported by: drew dot mclellan at gmail dot com Summary: imageconvolution processing output inconsistent with previous versions -Status: Open +Status: Closed Type: Bug Package: GD related Operating System: Linux PHP Version: 5.5.9 -Assigned To: +Assigned To: stas Block user comment: N Private report: N New Comment: Thank you for your bug report. This issue has already been fixed in the latest released version of PHP, which you can download at http://www.php.net/downloads.php Looks like 5.5.11 fixed it. Please reopen if still happens on current 5.5. Previous Comments: ------------------------------------------------------------------------ [2014-03-06 19:17:08] brad at bradleyboy dot com Not sure why it didn't make it into 5.5.10, but looks like it will be in 5.5.11 according to this: https://github.com/php/php-src/blob/PHP-5.5/NEWS ------------------------------------------------------------------------ [2014-03-06 18:51:20] chris at lodesys dot com Still seeing this bug in 5.5.10. Cannot upgrade from 5.5.8 until the fix is incorporated. ------------------------------------------------------------------------ [2014-02-19 22:12:22] chrispmaiden at gmail dot com I can confirm Brad's findings, it looks like this commit https://github.com/php/php-src/commit/2938329ce19cb8c4197dec146c3ec887c6f61d01 introduced the problem. It's the only change in imageconvolution between the two versions and looks like a simple typo. ------------------------------------------------------------------------ [2014-02-19 21:28:00] brad at bradleyboy dot com I have limited C knowledge, but this looks like a simple typo in a recent change. Pull request here: https://github.com/php/php-src/pull/597 ------------------------------------------------------------------------ [2014-02-19 17:57:42] brad at bradleyboy dot com Here's an image to show the visual differences between 5.5.8 and 5.5.9. As Drew notes, it's significant. These tests were run on OS X, but the issue is also present on Linux (and I assume Windows, but do not have a way to test that to confirm). In the test, the following matrix was applied: $matrix = array(array(-1, -1, -1), array(-1, 20, -1), array(-1, -1, -1)); $divisor = array_sum(array_map('array_sum', $matrix)); imageconvolution($image, $matrix, $divisor, 0); Result: http://bradleyboy.com/php-5.5.9-imageconvolution.jpg ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=66714 -- Edit this bug report at https://bugs.php.net/bug.php?id=66714&edit=1