Bug #67167 [Asn]: Wrong return value from FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE

Edit report at https://bugs.php.net/bug.php?id=67167&edit=1 ID: 67167 Updated by: levim@php.net Reported by: peter dot schultz at classmarkets dot com Summary: Wrong return value from FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE Status: Assigned Type: Bug Package: Filter related Operating System: Fedora 20 PHP Version: 5.5.12 Assigned To: levim Block user comment: N Private report: N New Comment: Here's the exact quote: > If FILTER_NULL_ON_FAILURE is set, FALSE is returned only for "0", "false", > "off", "no", and "", and NULL is returned for all non-boolean values. It seems I misread; that does sound like it should return null for anything that fails is_bool. Previous Comments: ------------------------------------------------------------------------ [2014-05-08 05:18:27] infinitythe7th at gmx dot net According to the Documentation here: http://www.php.net/manual/en/filter.filters.validate.php The filter FILTER_VALIDATE_BOOLEAN with the flag FILTER_NULL_ON_FAILURE shall "[return] NULL [...] for all non-boolean values". In my opinion "null" is clearly a non-boolean value, so i can't really understand why you would classify it returning false as being "by design". ------------------------------------------------------------------------ [2014-05-08 05:18:26] levim@php.net I have a PR open for this issue; hopefully it will get resolved soon. ------------------------------------------------------------------------ [2014-05-08 05:06:28] levim@php.net I have a fix pending for when an object that does not have a __toString method is passed. Based on existing code and bug reports, it seems that casting to a string is by-design; this means that passing null to filter_var would get cast to '' (empty string) which results in filter_var returning false, not NULL (see http://www.php.net/manual/en/filter.filters.validate.php) ------------------------------------------------------------------------ [2014-05-07 16:09:49] levim@php.net It appears that pajoye is correct; there is a convert_to_string call that messes all of this up. I'm not exactly sure what to do; it seems a rewrite is necessary to fix this behavior and that is beyond my current skill level. I could just bypass the convert_to_string call and special case this bug but that seems like a really bad idea. ------------------------------------------------------------------------ [2014-05-07 15:16:49] pajoye@php.net Keep in mind that the problem (if you pass booleans as well) is the string conversion happening before the filter is called. Making all Boolean checks impossible. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=67167 -- Edit this bug report at https://bugs.php.net/bug.php?id=67167&edit=1