Bug #67186 [Asn->Fbk]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql

From:	tyrael@php.net	Date:	Tue, 13 May 2014 15:47:57 +0000
Subject:	Bug #67186 [Asn->Fbk]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql
References:	1	Groups:	php.bugs
Request:	Send a blank email to php-bugs+get-185806@lists.php.net to get a copy of this message

Edit report at https://bugs.php.net/bug.php?id=67186&edit=1

 ID:                 67186
 Updated by:         tyrael@php.net
 Reported by:        andy at webtatic dot com
 Summary:            PHP 5.6.0beta2 fails to compile when compiling
                     mysqli extension with libmysql
-Status:             Assigned
+Status:             Feedback
 Type:               Bug
 Package:            MySQLi related
 Operating System:   all
 PHP Version:        5.6.0beta2
 Assigned To:        mysql
 Block user comment: N
 Private report:     N



Previous Comments:
------------------------------------------------------------------------
[2014-05-06 10:16:13] andrey@php.net

Could you try trunk or 5.6 head?

Andrey

------------------------------------------------------------------------
[2014-05-05 19:10:20] andy at webtatic dot com

Sorry I mean Adam not Alex :)

------------------------------------------------------------------------
[2014-05-05 19:07:46] andy at webtatic dot com

I think in the very least one of the following is done

1) Removing the MYSQLI_STORE_RESULT_OFS constant (which it being a typo, isn't used), and
implementing the ALIAS constant the same way Alex changed the COPY_DATA one

or

2) Replacing the change with my solution

Otherwise, having two competing implementations of both constants may be confusing.

------------------------------------------------------------------------
[2014-05-05 17:55:53] aharvey@php.net

In theory, my commit (linked above) should fix this, but as Andy says, there may be a simpler
solution.

Friendly people of the MySQL team, what would you prefer? I was aiming to match the other places
MYSQLI_STORE_RESULT_COPY_DATA was used, but if #define 0 is an option, that might be cleaner.

------------------------------------------------------------------------
[2014-05-03 07:31:22] andy at webtatic dot com

I see someone has already implemented a fix (although more complex solution that doesn't match
the way MYSQLI_ASYNC is done)

https://github.com/php/php-src/commit/06a03bbfa60bedb3f30bb2908449fc30d54f848e

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=67186


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=67186&edit=1


   

Thread (8 messages)

• andy at webtatic dot comSat, 03 May 2014 07:13:20 +0000
  • andy at webtatic dot comSat, 03 May 2014 07:31:22 +0000Bug #67186 [Com]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql
  • aharvey@php.netMon, 05 May 2014 17:55:54 +0000Bug #67186 [Opn->Asn]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql
  • andy at webtatic dot comMon, 05 May 2014 19:07:46 +0000Bug #67186 [Com]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql
  • andy at webtatic dot comMon, 05 May 2014 19:10:20 +0000Bug #67186 [Com]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql
  • andrey@php.netTue, 06 May 2014 10:16:13 +0000Bug #67186 [Asn]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql
  • tyrael@php.netTue, 13 May 2014 15:47:57 +0000Bug #67186 [Asn->Fbk]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql
  • php-bugs at lists dot php dot netTue, 30 Dec 2014 10:42:35 +0000Bug #67186 [Fbk->NoF]: PHP 5.6.0beta2 fails to compile when compiling mysqli extension with libmysql