Bug #67118 [Com]: DateTime constructor crash with invalid data

From:	slusarz at curecanti dot org	Date:	Fri, 06 Jun 2014 23:36:17 +0000
Subject:	Bug #67118 [Com]: DateTime constructor crash with invalid data
References:	1	Groups:	php.bugs
Request:	Send a blank email to php-bugs+get-186089@lists.php.net to get a copy of this message

Edit report at https://bugs.php.net/bug.php?id=67118&edit=1

 ID:                 67118
 Comment by:         slusarz at curecanti dot org
 Reported by:        per at interapp dot se
 Summary:            DateTime constructor crash with invalid data
 Status:             Closed
 Type:               Bug
 Package:            Reproducible crash
 Operating System:   Windows 2008 R2
 PHP Version:        5.5.11
 Assigned To:        ab
 Block user comment: N
 Private report:     N

 New Comment:

See: http://lists.horde.org/archives/dev/Week-of-Mon-20140602/028641.html

In short: After these fixes

http://git.php.net/?p=php-src.git;a=commit;h=1fe9f1e4f572d7b4d5a3872f41ea61e71fb563bf
http://git.php.net/?p=php-src.git;a=commit;h=15d8c80ead75be976c18a66b0933cf52f3e6579f

I believe the behavior is correct.

However, these temporary fixes were reverted in master.  See:

http://git.php.net/?p=php-src.git;a=commit;h=f11f7f56013c5ee4e6009997602e9b5a64064909

As described in the e-mail linked above, this returns to incorrect behavior because it causes
DateTime to act entirely different from every other class when an exception is thrown in the
constructor.  A class that extends a constructor should be allowed to do whatever is necessary to
try to fix the issue and should not artificially be disallowed from accessing itself because of an
exception below it.


Previous Comments:
------------------------------------------------------------------------
[2014-06-06 08:15:37] arjen at react dot com

Regression was reported in https://bugs.php.net/bug.php?id=67179
Which can be closed now...

------------------------------------------------------------------------
[2014-06-05 12:51:38] remi@php.net

This introduce a regression in some code.

Fixed in 
http://git.php.net/?p=php-src.git;a=commit;h=1fe9f1e4f572d7b4d5a3872f41ea61e71fb563bf
http://git.php.net/?p=php-src.git;a=commit;h=15d8c80ead75be976c18a66b0933cf52f3e6579f

------------------------------------------------------------------------
[2014-05-01 14:59:15] tyrael@php.net

Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=c1aa9baf29d1a20fa60c1cef3979a80014f6677b
Log: Fixed bug #67118 DateTime constructor crash with invalid data

------------------------------------------------------------------------
[2014-04-28 11:18:44] per at interapp dot se

Hi Anatol,

Thanks a lot for the fix. It is applied in production now and everything is working great. Actually
we didn't believe we would be able to provide you with a code snippet for reproduction either
:)

Thanks once again

BR Eric

------------------------------------------------------------------------
[2014-04-25 23:29:32] ab@php.net

Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=c1aa9baf29d1a20fa60c1cef3979a80014f6677b
Log: Fixed bug #67118 DateTime constructor crash with invalid data

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=67118


--
Edit this bug report at https://bugs.php.net/bug.php?id=67118&edit=1


   

Thread (21 messages)

• per at interapp dot seWed, 23 Apr 2014 14:51:16 +0000
  • per at interapp dot seWed, 23 Apr 2014 14:52:13 +0000Bug #67118 [Opn]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seWed, 23 Apr 2014 15:11:10 +0000Bug #67118 [Com]: php-cgi crashes regularly on IIS 7
  • ab@php.netWed, 23 Apr 2014 23:16:16 +0000Bug #67118 [Opn->Fbk]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seThu, 24 Apr 2014 06:41:07 +0000Bug #67118 [Fbk->Opn]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seThu, 24 Apr 2014 06:58:54 +0000Bug #67118 [Com]: php-cgi crashes regularly on IIS 7
  • ab@php.netThu, 24 Apr 2014 10:09:31 +0000Bug #67118 [Opn->Fbk]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seThu, 24 Apr 2014 12:20:25 +0000Bug #67118 [Com]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seThu, 24 Apr 2014 19:39:04 +0000Bug #67118 [Com]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seThu, 24 Apr 2014 20:01:10 +0000Bug #67118 [Com]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seThu, 24 Apr 2014 21:07:59 +0000Bug #67118 [Com]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seFri, 25 Apr 2014 09:08:22 +0000Bug #67118 [Fbk->Asn]: php-cgi crashes regularly on IIS 7
  • per at interapp dot seFri, 25 Apr 2014 11:55:43 +0000Bug #67118 [Com]: php-cgi crashes regularly on IIS 7
  • ab@php.netFri, 25 Apr 2014 12:00:33 +0000Bug #67118 [Asn]: php-cgi crashes regularly on IIS 7
  • ab@php.netFri, 25 Apr 2014 15:28:22 +0000Bug #67118 [Asn->Csd]: DateTime constructor crash with invalid data
  • ab@php.netFri, 25 Apr 2014 16:43:40 +0000Bug #67118 [Csd]: DateTime constructor crash with invalid data
  • per at interapp dot seMon, 28 Apr 2014 11:18:45 +0000Bug #67118 [Csd]: DateTime constructor crash with invalid data
  • remi@php.netThu, 05 Jun 2014 12:51:38 +0000Bug #67118 [Com]: DateTime constructor crash with invalid data
  • arjen at react dot comFri, 06 Jun 2014 08:15:38 +0000Bug #67118 [Com]: DateTime constructor crash with invalid data
  • slusarz at curecanti dot orgFri, 06 Jun 2014 23:36:17 +0000Bug #67118 [Com]: DateTime constructor crash with invalid data
  • datibbaw@php.netMon, 25 Aug 2014 00:21:19 +0000Bug #67118 [Csd]: DateTime constructor crash with invalid data