Bug #67572 [Opn]: SimpleXMLElement not parsing \n correctly (???)

From: Date: Tue, 08 Jul 2014 04:46:03 +0000
Subject: Bug #67572 [Opn]: SimpleXMLElement not parsing \n correctly (???)
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-186513@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=67572&edit=1 ID: 67572 Updated by: yohgaki@php.net Reported by: ondrej@php.net Summary: SimpleXMLElement not parsing \n correctly (???) Status: Open Type: Bug Package: SimpleXML related -Operating System: Debian (but probably any) +Operating System: any PHP Version: 5.6.0RC2 Block user comment: N Private report: N New Comment: http://3v4l.org/7vXEg It seems it's broken since 5.4.0. Previous Comments: ------------------------------------------------------------------------ [2014-07-04 13:10:58] ondrej@php.net Description: ------------ As reported here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=729476 Original report is for 5.4.x (Debian wheezy). --begin-- The documented behaviour of the empty() function is to be a shorthand for "!isset($var) || var == false". The below example shows a case where this fails, and was triggering a subtle bug in my code after upgrade of production server to Wheezy. I think this may well affect others and even be a security issue if "empty" variables are assumed to be safe. I noticed the issue running PHP under Apache but for simplicity the below example can just be run on the command line. I've not tested on any later PHP version, sorry. --end-- I have retested this on 5.6.0RC2. And what's even more strange, that if I add var_dump($value) to the last loop, I will get: ---cut here-- object(SimpleXMLElement)#5 (0) { } ---cut here-- even though dereferencing $value returns 'somevalue' correctly. Test script: --------------- <?php $foo = 'bar'; print "regular string ... "; var_dump(empty($foo)); #Should be false $xml = simplexml_load_string("<xml><something>somevalue</something></xml>"); $xml2 = simplexml_load_string("<xml>\n<something>somevalue</something>\n</xml>"); foreach($xml as $key => $value) { print "$key = $value ... "; var_dump(empty($value)); # Should be false var_dump($value == false); # Should be false } foreach($xml2 as $key => $value) { print "$key = $value ... "; var_dump(empty($value)); # Should be false, but isn't var_dump($value == false); # Should be false } ?> Expected result: ---------------- regular string ... bool(false) something = somevalue ... bool(false) bool(false) something = somevalue ... bool(false) bool(false) Actual result: -------------- regular string ... bool(false) something = somevalue ... bool(false) bool(false) something = somevalue ... bool(true) bool(false) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=67572&edit=1

« previous php.bugs (#186513) next »