Req #67553 [Com]: Add SIGHUP as a reload signal

From: Date: Wed, 09 Jul 2014 08:46:54 +0000
Subject: Req #67553 [Com]: Add SIGHUP as a reload signal
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-186543@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=67553&edit=1

 ID:                 67553
 Comment by:         remi@php.net
 Reported by:        ondrej@php.net
 Summary:            Add SIGHUP as a reload signal
 Status:             Open
 Type:               Feature/Change Request
 Package:            FPM related
 Operating System:   Linux
 PHP Version:        5.4.30
 Block user comment: N
 Private report:     N

 New Comment:

Currently, in provided php-fpm.service we have 

   ExecReload=/bin/kill -USR2 $MAINPID

So no issue encountered with "service php-fpm reload"

But, I think this change can make things more consistent.


Previous Comments:
------------------------------------------------------------------------
[2014-07-02 10:12:50] ondrej@php.net

The following patch has been added/updated:

Patch Name: php5-fpm-do-reload-on-SIGHUP.patch
Revision:   1404295970
URL:        https://bugs.php.net/patch-display.php?bug=67553&patch=php5-fpm-do-reload-on-SIGHUP.patch&revision=1404295970

------------------------------------------------------------------------
[2014-07-02 10:12:34] ondrej@php.net

Description:
------------
Both upstart and systemd are using SIGHUP as a default signal for reload action and the init scripts
needs special configuration because FPM uses SIGUSR2 for reload.

Since SIGHUP is unused in FPM there's no harm in adding it as another reload signal.

Patch attached.

Applies to all supported versions of PHP.

Test script:
---------------
service php5-fpm reload

Expected result:
----------------
PHP FPM reloaded

Actual result:
--------------
PHP FPM in invalid state - main process crashed without killing children processes.


------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=67553&edit=1


Thread (3 messages)

« previous php.bugs (#186543) next »