Bug #67655 [Opn]: php_strip_whitespace outputs warnings instead of going through the error_handle
Edit report at https://bugs.php.net/bug.php?id=67655&edit=1
ID: 67655
Updated by: yohgaki@php.net
Reported by: seld@php.net
Summary: php_strip_whitespace outputs warnings instead of
going through the error_handle
Status: Open
Type: Bug
-Package: Output Control
+Package: Scripting Engine problem
Operating System: Linux
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
This happens because these syntax errors are handled in Zend.
Output control is PHP feature, while language scanner is Zend.
highlight_file(), etc may have same issue.
Previous Comments:
------------------------------------------------------------------------
[2014-07-19 22:25:22] seld@php.net
Description:
------------
php_strip_whitespace appears to be bypassing the error handler and output buffering. If you run it
in CLI and there is a warning like "Unterminated comment starting line .." then that is
output to the user with no chance to intercept.
More infos at https://github.com/composer/composer/issues/3030
and a test run showing various issues at http://3v4l.org/pS3LE
The only workaround found was to @-silence the call, which is alright but I thought I'd report
it anyway because it's pretty strange behavior.
Test script:
---------------
<?php
function log_error($num, $str, $file, $line, $context = null) {
throw new ErrorException( $str, 0, $num, $file, $line );
}
set_error_handler('log_error');
ob_start();
// uncommenting the line below might help surface the problem:
//error_reporting(-1); ini_set('display_errors', 1);
file_put_contents('test.php', '<?php /*');
$out = php_strip_whitespace('test.php');
unlink('test.php');
var_dump(ob_get_clean(), $out);
Expected result:
----------------
string(0) ""
string(6) "<?php "
Actual result:
--------------
Warning: Unterminated comment starting line 1 in repro.php on line 9
string(0) ""
string(6) "<?php "
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=67655&edit=1
Thread (2 messages)