Bug #67694 [PATCH]: Regression in session_regenerate_id()

From: Date: Sat, 23 Aug 2014 14:18:30 +0000
Subject: Bug #67694 [PATCH]: Regression in session_regenerate_id()
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-187252@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=67694&edit=1

 ID:                 67694
 Patch added by:     tyrael@php.net
 Reported by:        atze at fem dot tu-ilmenau dot de
 Summary:            Regression in session_regenerate_id()
 Status:             Closed
 Type:               Bug
 Package:            Session related
 Operating System:   GNU/Linux i386
 PHP Version:        5.6.0RC2
 Assigned To:        yohgaki
 Block user comment: N
 Private report:     N

 New Comment:

The following patch has been added/updated:

Patch Name: write-short-circuit-fix
Revision:   1408803509
URL:        https://bugs.php.net/patch-display.php?bug=67694&patch=write-short-circuit-fix&revision=1408803509


Previous Comments:
------------------------------------------------------------------------
[2014-08-23 07:19:44] tyrael@php.net

ignore the first patch, I screwed up.

------------------------------------------------------------------------
[2014-08-23 07:15:58] tyrael@php.net

The following patch has been added/updated:

Patch Name: write-short-circuit-fix
Revision:   1408778157
URL:        https://bugs.php.net/patch-display.php?bug=67694&patch=write-short-circuit-fix&revision=1408778157

------------------------------------------------------------------------
[2014-08-23 01:22:28] datibbaw@php.net

Automatic comment on behalf of datibbaw
Revision: http://git.php.net/?p=php-src.git;a=commit;h=ce9bdae33f101ff85c08d32ce5c2c6502a451d62
Log: Fixed #67694: Regression in session_regenerate_id()

------------------------------------------------------------------------
[2014-08-23 00:47:47] datibbaw@php.net

I've tried to write a test case against this, but unfortunately it passes on 5.6; perhaps
somebody can improve it?

https://gist.github.com/datibbaw/6fd22f567f1ef2436ddb

------------------------------------------------------------------------
[2014-08-22 23:56:40] tyrael@php.net

sorry for not spotting this sooner (I remembered that I checked this and couldn't repro, but
maybe I just remember wrong).
I was able to reproduce the issue with RC4, from a quick search, it seems that this was introduced
with
http://git.php.net/?p=php-src.git;a=commit;h=554021d21e1b2517313a377676260c188152c2eb
http://bugs.php.net/17860
Assigning this Yasuo, but others are also welcome to look into this.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=67694


--
Edit this bug report at https://bugs.php.net/bug.php?id=67694&edit=1


Thread (13 messages)

« previous php.bugs (#187252) next »