Bug #68014 [Com]: Result data values can be truncated because of incorrect column display sizes

Edit report at https://bugs.php.net/bug.php?id=68014&edit=1 ID: 68014 Comment by: git at duncanc dot co dot uk Reported by: marcus dot england at noaa dot gov Summary: Result data values can be truncated because of incorrect column display sizes Status: Open Type: Bug Package: ODBC related Operating System: All PHP Version: >= 5.4.32 Block user comment: N Private report: N New Comment: I have not seen this issue when using a 32bit OS, but I can confirm the issue is present on 5.6.0 (linux 64bit). Also tested the patch and it corrected the issue Previous Comments: ------------------------------------------------------------------------ [2014-09-17 14:34:51] marcus dot england at noaa dot gov Introduced in version 5.4.32... ------------------------------------------------------------------------ [2014-09-12 20:16:41] marcus dot england at noaa dot gov Description: ------------ The FieldIdentifier is being incorrectly set in the call to SQLColAttributes within the odbc_bindcols function in the ext/odbc/php_odbc.c file. Bug was introduced in version 5.4.32 and is present in all subsequent versions. In the column FOR loop, if the field identifier variable (colfieldid) is changed from SQL_COLUMN_DISPLAY_SIZE to SQL_DESC_OCTET_LENGTH for a SQL_CHAR, SQL_VARCHAR, SQL_WCHAR, or SQL_WVARCHAR column type, it will remain that way for any remaining columns in the table regardless of type. This causes SQLColAttributes to be called with the wrong identifier which returns an incorrect display size. In the case of a table with TINYINTs, this causes the displaysize to be incorrectly set to 1 rather than 3, resulting in too little memory being allocated for the result value, truncating the data. Test script: --------------- I tested with a table of tinyint's and varchar(20)'s with SQL Server and FreeTDS. tinyint columns that follow a varchar are incorrectly set to displaysize of 1 resulting in a truncation of the data, e.g. 85 becomes an 8. The displaysize should be 3. Expected result: ---------------- If we reset the FieldIdentifier to SQL_COLUMN_DISPLAY_SIZE for each iteration of the column loop, the bug is fixed. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=68014&edit=1