Req #68458 [Csd]: Change pm.start_servers default warning to notice
| From: | remi@php.net | Date: | Thu, 20 Nov 2014 07:18:55 +0000 |
| Subject: | Req #68458 [Csd]: Change pm.start_servers default warning to notice | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-188706@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=68458&edit=1
ID: 68458
Updated by: remi@php.net
Reported by: dz at heroku dot com
Summary: Change pm.start_servers default warning to notice
Status: Closed
Type: Feature/Change Request
Package: FPM related
Operating System: OS X 10.8.5
PHP Version: 5.6.3
-Assigned To:
+Assigned To: remi
Block user comment: N
Private report: N
New Comment:
Commits:
http://git.php.net/?p=php-src.git;a=commitdiff;h=909d44f20dd00ccf3a6519707bfaba2ed30e8b2b
http://git.php.net/?p=php-src.git;a=commitdiff;h=befce20c84527181f760fb53e4d536f22e84953e
http://git.php.net/?p=php-src.git;a=commitdiff;h=49be4af42bdb4ae013cfd5a9739c1639056b7e12
http://git.php.net/?p=php-src.git;a=commitdiff;h=a128cbad578adbb2ca16ae84c8b2fef609067c8d
I also add a second test, your in "warning" level (nothing traced), another in
"notice" level, to check everything is traced.
Previous Comments:
------------------------------------------------------------------------
[2014-11-20 07:16:32] remi@php.net
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=dec0db79c3fc0c284cef9a04801b3d4d068522b2
Log: Fixed #68458 Change pm.start_servers default warning to notice
------------------------------------------------------------------------
[2014-11-20 07:15:50] remi@php.net
Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1939097ededdbf1d42305e32f6a9947ff6a7e91f
Log: Fixed #68458 Change pm.start_servers default warning to notice
------------------------------------------------------------------------
[2014-11-19 22:44:25] dz at heroku dot com
Had to move the location of
zlog_set_level() again (see https://bugs.php.net/bug.php?id=68381), see PR for
details.
------------------------------------------------------------------------
[2014-11-19 22:43:04] dz at heroku dot com
Description:
------------
Unlike other settings, this has a perfectly reasonable default, calculated using a dynamic formula.
If the default were hardcoded to "2" or something, then it would make sense to have a
warning, since that could potentially be bad, but for a dynamically calculated value based on other
mandatory settings, a notice ought to be enough.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=68458&edit=1