Req #68424 [Fbk->NoF]: Add new PDO mysql connection attr to control multi statements option
Edit report at https://bugs.php.net/bug.php?id=68424&edit=1
ID: 68424
Updated by: php-bugs@lists.php.net
Reported by: peter dot wolanin at acquia dot com
Summary: Add new PDO mysql connection attr to control multi
statements option
-Status: Feedback
+Status: No Feedback
Type: Feature/Change Request
Package: PDO MySQL
Operating System: all
PHP Version: 5.6.3
Private report: N
New Comment:
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Re-Opened". Thank you.
Previous Comments:
------------------------------------------------------------------------
[2014-12-05 16:09:04] jpauli@php.net
Please try using this snapshot:
http://snaps.php.net/php5.5-latest.tar.gz
For Windows:
http://windows.php.net/snapshots/
------------------------------------------------------------------------
[2014-11-14 15:02:29] peter dot wolanin at acquia dot com
Description:
------------
Proposed fix: https://github.com/php/php-src/pull/896
mysqli does not set the CLIENT_MULTI_STATEMENTS flag on connect, so a query with multiple statements
fails.
For PDO mysql, it hard-codes the CLIENT_MULTI_STATEMENTS flag in the connection, so there is no way
to disable it. However, if using native prepares, sending multiple statements fails on the server.
This is inconsistent.
This PR adds a new MySQL-specific attribute that can be only set at connection time to explicitly
enable or disable multi statements. As written, it leaves the default the same as current master
(enabled).
While this PR is against master, I think this change falls somewhere between a feature and a bugfix
and should be back-ported to all supported versions.
The motivation for this is the severity of the recent SQL injection vulnerability in Drupal. If we
had any way to disable multi statement in PDO (which is used in Drupal 7.x but not 6.x), we would
have, and the vulnerability would have been significantly mitigated. see: https://www.drupal.org/SA-CORE-2014-005
Test script:
---------------
https://github.com/php/php-src/pull/896
includes added test.
Expected result:
----------------
It should be possible to limit PDO MySQL to single statement execution so it behaves like mysqli
Actual result:
--------------
multi-statement option is hard-coded into the connection logic
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=68424&edit=1
Thread (4 messages)