Bug #68697 [Opn->Csd]: lo_export return -1 on failure

Edit report at https://bugs.php.net/bug.php?id=68697&edit=1 ID: 68697 Updated by: aharvey@php.net Reported by: ondrej@php.net Summary: lo_export return -1 on failure -Status: Open +Status: Closed Type: Bug Package: *General Issues PHP Version: 5.6Git-2014-12-30 (Git) -Assigned To: +Assigned To: ondrej Block user comment: N Private report: N New Comment: Thanks Ondřej! Merged to 5.5, 5.6 and master. I haven't merged this to 5.4, given that's in security fix only mode — this may be so tiny and obviously correct that Stas will allow it if you ask, but I'm not comfortable committing it unless he gives a +1. Previous Comments: ------------------------------------------------------------------------ [2014-12-30 16:23:32] ondrej@php.net The following patch has been added/updated: Patch Name: check-libpq-lo_export-return-value.patch Revision: 1419956611 URL: https://bugs.php.net/patch-display.php?bug=68697&patch=check-libpq-lo_export-return-value.patch&revision=1419956611 ------------------------------------------------------------------------ [2014-12-30 15:31:01] ondrej@php.net Description: ------------ libpq lo_export returns -1 on failure, but PHP code doesn't check for -1, but for "!= 0" Also affects PHP-5.4 and PHP-5.5. Test script: --------------- As reported in Debian BTS: bugs.debian.org/773182 Expected result: ---------------- returns FALSE on failure Actual result: -------------- return TRUE on failure ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=68697&edit=1