Bug #67960 [Ver->Csd]: Long/short day names reversed in jddayofweek()

Edit report at https://bugs.php.net/bug.php?id=67960&edit=1 ID: 67960 Updated by: tyrael@php.net Reported by: fisharebest at gmail dot com Summary: Long/short day names reversed in jddayofweek() -Status: Verified +Status: Closed Type: Bug Package: Calendar related Operating System: All PHP Version: 5.6.0 Assigned To: tyrael Block user comment: N Private report: N New Comment: The fix for this bug has been committed. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. For Windows: http://windows.php.net/snapshots/ Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2014-09-04 21:35:31] fisharebest at gmail dot com Pull request available, with updated unit tests... https://github.com/php/php-src/pull/806 ------------------------------------------------------------------------ [2014-09-04 15:53:30] tyrael@php.net ah, that would keep the previous behavior for the people who are passing numeric values for the mode instead of using the constants. ------------------------------------------------------------------------ [2014-09-04 15:39:27] tyrael@php.net why do you think we should change the order of declaration in the enum? ------------------------------------------------------------------------ [2014-09-04 15:29:12] fisharebest at gmail dot com I think you need to: 1) reverse the order in the enum {} declaration 2) reverse the two labels in the case statement I have a patch/tests, but can't get the latest code to build so can't test it. I'll try again tonight when I have access to another dev machine. ------------------------------------------------------------------------ [2014-09-04 14:07:09] tyrael@php.net haha, nice catch, this seems to be wrong since the begining: http://3v4l.org/OXRAC the fix should be swapping the lines here: http://lxr.php.net/xref/PHP_5_6/ext/calendar/calendar.c#699 I suppose this could also go into 5.5 as well. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=67960 -- Edit this bug report at https://bugs.php.net/bug.php?id=67960&edit=1