Bug #68751 [Com]: listen.allowed_clients is broken

From: Date: Tue, 06 Jan 2015 18:39:12 +0000
Subject: Bug #68751 [Com]: listen.allowed_clients is broken
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-189690@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=68751&edit=1

 ID:                 68751
 Comment by:         iquito at gmx dot ch
 Reported by:        remi@php.net
 Summary:            listen.allowed_clients is broken
 Status:             Closed
 Type:               Bug
 Package:            FPM related
 Operating System:   GNU/LInux
 PHP Version:        5.5.20
 Assigned To:        remi
 Block user comment: N
 Private report:     N

 New Comment:

I have a problem with PHP-FPM which seems to be connected to this bug. The detailed version is on https://github.com/gplessis/dotdeb-php5/issues/69
, the short of it is:

When multiple addresses are listed in listen.allowed_clients for just one FPM pool config, FPM
terminates any further connections from any IP addresses of any pool after one request to any of the
pools (as far as I can tell). Only if all pools only have one IP address in listen.allowed_clients
FPM seems to work normally again.

This has lead to a complete FPM failure on all of my servers without a hint of where the problem
occured, except it is somehow related to FPM, as CLI still worked.

In my opinion, PHP 5.5.20 should not be further distributed as long as this bug is contained in it,
as existing configurations are likely to break - multiple IPs in listen.allowed_clients seem a
common configuration choice, and mitigating this problem is not straightforward.


Previous Comments:
------------------------------------------------------------------------
[2015-01-06 10:21:14] igor dot ajdisek at gmail dot com

I can confirm this now works. I no longer see any 'Connection disallowed' errors and all
requests succeed.

------------------------------------------------------------------------
[2015-01-06 10:08:01] remi@php.net

@samo: you're right.

Cleanup: http://git.php.net/?p=php-src.git;a=commitdiff;h=8404f8ac2a540780422d9813138a9c6785405312

------------------------------------------------------------------------
[2015-01-06 09:30:26] samo dot bracic at gmail dot com

The line 40, where int_addr_t is defined, seems to be redundant after this change.

  40         typedef unsigned int in_addr_t;

Or am I mistaken?

------------------------------------------------------------------------
[2015-01-05 16:36:42] remi@php.net

Automatic comment on behalf of remi
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1b6d076244c0f7686fa611f7988247ee26ce58c5
Log: Fix bug #68751 listen.allowed_clients is broken

------------------------------------------------------------------------
[2015-01-05 16:29:14] remi@php.net

Description:
------------
When multiple address listed, only work of fist call (of each child), then connection from not-first
address fails.




------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=68751&edit=1


Thread (13 messages)

« previous php.bugs (#189690) next »