Bug #68792 [Com]: Can't declare closure using $this within static method (context)

Edit report at https://bugs.php.net/bug.php?id=68792&edit=1 ID: 68792 Comment by: levim@php.net Reported by: llmll at gmx dot de Summary: Can't declare closure using $this within static method (context) Status: Duplicate Type: Bug Package: Scripting Engine problem Operating System: any PHP Version: 5.5.20 Block user comment: N Private report: N New Comment: > I really mean no offense, but this fix of yours is against all practical logic. This is still being hostile; please stop. As for static closures: they already existed. A static closure in PHP means that you don't capture the $this context. Again, I did not add this feature. > What could ever be the reason to make a closure depend on the declaring context? Look at this case (http://3v4l.org/105nh): <?php class A { static function foo() { $f = function() { return static::class; }; return $f(); } } class B extends A {} var_dump(B::foo()); ?> Before I patched it the result was string(1) "A" instead of string(1) "B". Is this any less valid that the code you want to work? I'm not suggesting they can't both be supported, but as it stands it how things are. Previous Comments: ------------------------------------------------------------------------ [2015-01-12 21:57:38] llmll at gmx dot de I really mean no offense, but this fix of yours is against all practical logic. Someone wanted static closures? Well, closures are static by definition. Atomic, independent pieces of code which can run in any context, thats the whole point of having closures. Convieniently, PHP allows to bind a closure to some object instance during runtime, which simplifies the use of $this. static:: then should point to the executing class context if available, we know that as late static binding. What could ever be the reaseon to make a closure depend on the declaring context? That really gives me gray hair. I humbly think this is absolutely wrong and should be re-fixed. However, thank you for reading and spending thoughts on this matter. ------------------------------------------------------------------------ [2015-01-12 21:31:14] levim@php.net > I really begin to wonder if you ever accept something is wrong, bogus, inconsistent or simply > stupid. You are being hostile. I am the person who made closures in static methods implicitly static as well, and I did so because of a bug report. So yes, I do accept things as bugs. Please be less accusatory in the future. ------------------------------------------------------------------------ [2015-01-12 16:00:26] llmll at gmx dot de You have to try the second example from my comment. There is a working snippet. Re-enable the commented "static" and it fails. That must not happen, as the static only tags the enclosing method, not the closure itself. I really begin to wonder if you ever accept something is wrong, bogus, inconsistent or simply stupid. Claiming that a clear bug happens the same way as last year doesn't make it any better for anybody. ------------------------------------------------------------------------ [2015-01-12 15:49:35] levim@php.net In any case, your example does not work on any version of PHP I am aware of. In versions 5.4.0 - 5.6.3, I get: Warning: Cannot bind an instance to a static closure in %s on line 10 Fatal error: Using $this when not in object context in %s on line 6 If you are going to convince me this is a bug then I need proof it ever worked. ------------------------------------------------------------------------ [2015-01-10 23:08:00] llmll at gmx dot de Thanks for your attention. However, the warning is wrong, since the closure is *not* static. It is merely defined in a static method. This shouldn't trigger the warning. The containing element should not have any impact on the closure itself. Removing the "static" keyword from the enclosing method, makes it work. Adding static, produces the error again. This is clearly incosistent und unexpected, besides it is not documented. class Test { public /*static*/ function start() { $closure = function() { echo $this->foo; }; $object = new \StdClass; $object->foo = "Hello World"; $closure->bindTo($object)->__invoke(); } } (new Test)->start(); ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=68792 -- Edit this bug report at https://bugs.php.net/bug.php?id=68792&edit=1