Bug #68823 [NEW]: Useles check

From: bugreports at internot dot info Operating system: Linux Ubuntu 14.04 PHP version: master-Git-2015-01-13 (Git) Package: *General Issues Bug Type: Bug Bug description:Useles check Description: ------------ Hi, In /main/php_open_temporary_file.c: 247#ifdef P_tmpdir 248 /* Use the standard default temporary directory. */ 249 if (P_tmpdir) { 250 temporary_directory = strdup(P_tmpdir); 251 return temporary_directory; 252 } 253#endif 249 if (P_tmpdir) { is useless due to 2 reasons: 1. it's an array, and cannot be NULL. 2. the check at line 247 should be fine as it is. Thanks, -- Edit bug report at https://bugs.php.net/bug.php?id=68823&edit=1 -- Try a snapshot (PHP 5.4): https://bugs.php.net/fix.php?id=68823&r=trysnapshot54 Try a snapshot (PHP 5.5): https://bugs.php.net/fix.php?id=68823&r=trysnapshot55 Try a snapshot (trunk): https://bugs.php.net/fix.php?id=68823&r=trysnapshottrunk Fixed in SVN: https://bugs.php.net/fix.php?id=68823&r=fixed Fixed in release: https://bugs.php.net/fix.php?id=68823&r=alreadyfixed Need backtrace: https://bugs.php.net/fix.php?id=68823&r=needtrace Need Reproduce Script: https://bugs.php.net/fix.php?id=68823&r=needscript Try newer version: https://bugs.php.net/fix.php?id=68823&r=oldversion Not developer issue: https://bugs.php.net/fix.php?id=68823&r=support Expected behavior: https://bugs.php.net/fix.php?id=68823&r=notwrong Not enough info: https://bugs.php.net/fix.php?id=68823&r=notenoughinfo Submitted twice: https://bugs.php.net/fix.php?id=68823&r=submittedtwice register_globals: https://bugs.php.net/fix.php?id=68823&r=globals PHP 4 support discontinued: https://bugs.php.net/fix.php?id=68823&r=php4 Daylight Savings: https://bugs.php.net/fix.php?id=68823&r=dst IIS Stability: https://bugs.php.net/fix.php?id=68823&r=isapi Install GNU Sed: https://bugs.php.net/fix.php?id=68823&r=gnused Floating point limitations: https://bugs.php.net/fix.php?id=68823&r=float No Zend Extensions: https://bugs.php.net/fix.php?id=68823&r=nozend MySQL Configuration Error: https://bugs.php.net/fix.php?id=68823&r=mysqlcfg