Bug #45081 [Asn->Csd]: strtotime incorrectly interprets SGT time zone

From: Date: Mon, 19 Jan 2015 22:59:57 +0000
Subject: Bug #45081 [Asn->Csd]: strtotime incorrectly interprets SGT time zone
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-190061@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=45081&edit=1

 ID:                 45081
 Updated by:         derick@php.net
 Reported by:        george dot wright at infimatic dot com
 Summary:            strtotime incorrectly interprets SGT time zone
-Status:             Assigned
+Status:             Closed
 Type:               Bug
 Package:            Date/time related
 Operating System:   SUSE 10.2
 PHP Version:        5.2.6
 Assigned To:        derick
 Block user comment: N
 Private report:     N

 New Comment:

Automatic comment on behalf of github@derickrethans.nl
Revision: http://git.php.net/?p=php-src.git;a=commit;h=b0159431e3363f6b15561c7dfa0cdb247c287223
Log: Fixed bug #45081 (strtotime incorrectly interprets SGT time zone).


Previous Comments:
------------------------------------------------------------------------
[2013-07-19 08:45:41] sdf at fake-email-address dot com

I don't see any evidence of this file being autogenerated. It's included in the 
source distribution. Maybe it's autogenerated at some point by someone, but the 
timezonedb.h that gets included in the build is essentially hard-coded and doesn't 
use the system timezonedb at any point.

If it is autogenerated, maybe it's time for someone to rebuild it and update the 
distribution.

------------------------------------------------------------------------
[2013-06-12 19:56:53] aharvey@php.net

That file is autogenerated from timezonedb, I believe.

------------------------------------------------------------------------
[2013-06-10 06:57:38] sdf at fake-email-address dot com

If only it were..

ext/date/lib/parse_date.c:

/* The timezone table. */
const static timelib_tz_lookup_table timelib_timezone_lookup[] = {
#include "timezonemap.h"
	{ NULL, 0, 0, NULL },
};

ext/date/lib/timezonemap.h:

	{ "acst",  1, -14400, "America/Porto_Acre"            },
	{ "acst",  1, -14400, "America/Eirunepe"              },
	{ "acst",  1, -14400, "America/Rio_Branco"            },
	{ "acst",  1, -14400, "Brazil/Acre"                   },
	{ "act",   0, -18000, "America/Porto_Acre"            },

etc. All hard coded.

------------------------------------------------------------------------
[2013-05-31 13:46:45] derick@php.net

Timezonedb is used for strtotime.

------------------------------------------------------------------------
[2013-05-30 23:44:24] sdf at fake-email-address dot com

Unfortunately not. The offsets are hard coded into PHP, timezonedb is not used for 
strtotime.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=45081


--
Edit this bug report at https://bugs.php.net/bug.php?id=45081&edit=1


Thread (11 messages)

« previous php.bugs (#190061) next »