Bug #68888 [NEW]: Useless Code

From: Date: Thu, 22 Jan 2015 14:37:19 +0000
Subject: Bug #68888 [NEW]: Useless Code
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-190149@lists.php.net to get a copy of this message 
From:             bugreports at internot dot info
Operating system: Linux Ubuntu 14.04
PHP version:      master-Git-2015-01-22 (Git)
Package:          *General Issues
Bug Type:         Bug
Bug description:Useless Code

Description:
------------
Hi,

In Zend/zend_operators.c:


        if (UNEXPECTED((zend_ulong)op2_lval >= SIZEOF_ZEND_LONG * 8)) {
                if (EXPECTED(op2_lval > 0)) {
                        ZVAL_LONG(result, 0);
                        return SUCCESS;
                } else {

If "op2_lval >= SIZEOF_ZEND_LONG * 8" is true, then "op2_lval > 0" will
always be true, no?


Thanks,


-- 
Edit bug report at https://bugs.php.net/bug.php?id=68888&edit=1
-- 
Try a snapshot (PHP 5.4):   https://bugs.php.net/fix.php?id=68888&r=trysnapshot54
Try a snapshot (PHP 5.5):   https://bugs.php.net/fix.php?id=68888&r=trysnapshot55
Try a snapshot (trunk):     https://bugs.php.net/fix.php?id=68888&r=trysnapshottrunk
Fixed in SVN:               https://bugs.php.net/fix.php?id=68888&r=fixed
Fixed in release:           https://bugs.php.net/fix.php?id=68888&r=alreadyfixed
Need backtrace:             https://bugs.php.net/fix.php?id=68888&r=needtrace
Need Reproduce Script:      https://bugs.php.net/fix.php?id=68888&r=needscript
Try newer version:          https://bugs.php.net/fix.php?id=68888&r=oldversion
Not developer issue:        https://bugs.php.net/fix.php?id=68888&r=support
Expected behavior:          https://bugs.php.net/fix.php?id=68888&r=notwrong
Not enough info:            https://bugs.php.net/fix.php?id=68888&r=notenoughinfo
Submitted twice:            https://bugs.php.net/fix.php?id=68888&r=submittedtwice
register_globals:           https://bugs.php.net/fix.php?id=68888&r=globals
PHP 4 support discontinued: https://bugs.php.net/fix.php?id=68888&r=php4
Daylight Savings:           https://bugs.php.net/fix.php?id=68888&r=dst
IIS Stability:              https://bugs.php.net/fix.php?id=68888&r=isapi
Install GNU Sed:            https://bugs.php.net/fix.php?id=68888&r=gnused
Floating point limitations: https://bugs.php.net/fix.php?id=68888&r=float
No Zend Extensions:         https://bugs.php.net/fix.php?id=68888&r=nozend
MySQL Configuration Error:  https://bugs.php.net/fix.php?id=68888&r=mysqlcfg

Thread (2 messages)

« previous php.bugs (#190149) next »