Bug #68941 [Csd->Asn]: mod_files.sh is a bash-script

Edit report at https://bugs.php.net/bug.php?id=68941&edit=1 ID: 68941 User updated by: bugzilla at ii dot nl Reported by: bugzilla at ii dot nl Summary: mod_files.sh is a bash-script -Status: Closed +Status: Assigned Type: Bug Package: Session related Operating System: linux PHP Version: Irrelevant Block user comment: N Private report: N New Comment: Apologies if you read my comment already, got no feedback from the UI to whom my comment got sent so I reopened. Previous Comments: ------------------------------------------------------------------------ [2015-01-29 09:07:26] bugzilla at ii dot nl Fix is incomplete, you forgot the 'sh' call at the bottom (I fell for this at first too) ------------------------------------------------------------------------ [2015-01-29 00:33:20] yohgaki@php.net Automatic comment on behalf of yohgaki Revision: http://git.php.net/?p=php-src.git;a=commit;h=abf9e2ea09e8776f411e7133cd5b838682260e4d Log: Fixed Bug #68941 mod_files.sh is a bash-script ------------------------------------------------------------------------ [2015-01-28 23:15:59] bugzilla at ii dot nl Description: ------------ The script references in the session.save-path documentation, mod_files.sh, found at https://github.com/php/php-src/blob/master/ext/session/mod_files.sh says #!/bin/sh at the top (and in the middle), but it uses [[ extensively which is a bashism. If your default shell isn't bash but dash, you end up with an quite deep subdirectory (0/0/0/0/0/.....) because the recursion won't stop. Fix is quite easy: change #!/bin/sh (and the call for sh later on) to #!/bin/bash. ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=68941&edit=1