Bug #69290 [Fbk->Opn]: Invalid modes do not trigger errors

Edit report at https://bugs.php.net/bug.php?id=69290&edit=1 ID: 69290 User updated by: roborg at gmail dot com Reported by: roborg at gmail dot com Summary: Invalid modes do not trigger errors -Status: Feedback +Status: Open Type: Bug Package: Program Execution Operating System: Windows PHP Version: 5.5.23 Block user comment: N Private report: N New Comment: Status Previous Comments: ------------------------------------------------------------------------ [2015-03-28 10:37:36] roborg at gmail dot com I've tested the script below with these results (sorry, I can't run these on the same OS): PHP: 5.3.5 OS: Win XP Mode: w Result: Script hangs PHP: 5.3.5 OS: Win XP Mode: a Result: Empty string PHP: 5.5.13 OS: Win 7 Mode: w Result: string 'x.......' PHP: 5.5.13 OS: Win 7 Mode: a Result: Empty string So the behavior has changed somewhat between 5.3 and 5.5, but not in the way I thought... It looks like the "a" mode never actually worked (as the output was empty), but just tricked PHP/Windows into not hanging. I still think failing silently is a really bad thing though. <?php $descriptors = array( array('pipe', 'r'), array('pipe', 'w'), array('pipe', 'w'), // This one changes between 'a' and 'w' ); $process = proc_open('c:\php\php.exe -r "$f = fopen(\'php://stderr\', \'w+\');fwrite($f, str_repeat(\'x\' . chr(10), 2048));', $descriptors, $pipes); var_dump(stream_get_contents($pipes[1])); var_dump(stream_get_contents($pipes[2])); proc_close($process); ------------------------------------------------------------------------ [2015-03-25 20:41:03] cmb@php.net This code has not been changed since 2003[1], so it's somewhat unlikely that a BC break has been introduced in PHP 5.x.y. If you can reproduce a behavioral change, please let us know (and change the bug status back to "Open"). [1] <https://github.com/php/php-src/commit/1a314027d3c388a19a06ac370fa08a46d474e1bd#diff-19f692ed5f75687fc7bc1929910e540fR337> ------------------------------------------------------------------------ [2015-03-25 17:27:58] roborg at gmail dot com I found the issue in my code because I was passing in "a" as recommended in http://php.net/proc_open#97012 and I wasn't getting any output. I'm pretty confident it used to work, so to me it seems BC has already been broken, as it's changed from working to failing silently - I'd rather it changed from working to giving an error (/warning/notice). ------------------------------------------------------------------------ [2015-03-25 09:29:53] laruence@php.net in proc_open: if (strncmp(Z_STRVAL_PP(zmode), "w", 1) != 0) { descriptors[ndesc].parentend = newpipe[1]; descriptors[ndesc].childend = newpipe[0]; descriptors[ndesc].mode |= DESC_PARENT_MODE_WRITE; } else { descriptors[ndesc].parentend = newpipe[0]; descriptors[ndesc].childend = newpipe[1]; } so, it's very clear why no notice was raised(assume "r" by default). considering bc issue, and not very helpful notices.... maybe change to a doc issue is better. ------------------------------------------------------------------------ [2015-03-24 15:52:53] roborg at gmail dot com Description: ------------ Valid modes for pipes are "r" and "w" according to the docs. Though a comment in the docs suggests using "a" for STDERR on Windows, I believe this may be outdated. Modes other than "r" and "w" (and possibly "a"?) should trigger an error, but are silently ignored and the pipe just doesn't work properly. Test script: --------------- $descriptors = array( array('pipe', 'x'), array('pipe', 'y'), array('pipe', 'z'), ); $process = proc_open('ls', $descriptors, $pipes); proc_close($process); Expected result: ---------------- Error: proc_open(): x is not a valid descriptor mode Actual result: -------------- (nothing) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=69290&edit=1